Feedback

Omer Lakraa · Omer Lakraa · commit e36d9968152b · 2025-03-21T16:44:56.000+01:00
diff --git a/src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md b/src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md
@@ -14,6 +14,8 @@ CHANGELOG
  * Add support for signal plain name in the `messenger.stop_worker_on_signals` configuration
  * Deprecate the `framework.validation.cache` option
  * Add `--method` option to the `debug:router` command
+ * Add exception.x.log_channel
+ * Allow configuring the logging channel per type of exceptions
 
 7.2
 ---
@@ -35,9 +37,6 @@ CHANGELOG
  * Add support for configuring multiple serializer instances via the configuration
  * Add support for `SYMFONY_TRUSTED_PROXIES`, `SYMFONY_TRUSTED_HEADERS`, `SYMFONY_TRUST_X_SENDFILE_TYPE_HEADER` and `SYMFONY_TRUSTED_HOSTS` env vars
  * Add `--no-fill` option to `translation:extract` command
- * Add exception.x.log_channel
- * Add a new logging channel for exceptions to provide better granularity and control over exception logging.
- * Allow configuring the logging channel per type of exceptions
 
 7.1
 ---
diff --git a/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php b/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
@@ -1460,6 +1460,7 @@ private function addExceptionsSection(ArrayNodeDefinition $rootNode): void
                             ->end()
                             ->scalarNode('log_channel')
                                 ->info('The channel of log message. Null to let Symfony decide.')
+                                ->defaultNull()
                             ->end()
                         ->end()
                     ->end()
diff --git a/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php b/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
@@ -421,8 +421,8 @@ public function load(array $configs, ContainerBuilder $container): void
         }
         
         $exceptionListener
-            ->replaceArgument(3, $config['exceptions'])
-            ->replaceArgument(4, $loggers)
+            ->setArgument(3, $config['exceptions'])
+            ->setArgument(4, $loggers)
         ;
 
         if ($this->readConfigEnabled('serializer', $container, $config['serializer'])) {
diff --git a/src/Symfony/Component/HttpKernel/CHANGELOG.md b/src/Symfony/Component/HttpKernel/CHANGELOG.md
@@ -6,17 +6,16 @@ CHANGELOG
 
  * Add `$key` argument to `#[MapQueryString]` that allows using a specific key for argument resolving
  * Support `Uid` in `#[MapQueryParameter]`
-
+ * Allow configuring the logging channel per type of exceptions in ErrorListener
+ 
 7.2
 ---
 
  * Remove `@internal` flag and add `@final` to `ServicesResetter`
  * Add support for `SYMFONY_DISABLE_RESOURCE_TRACKING` env var
  * Add support for configuring trusted proxies/headers/hosts via env vars
  * Remove `@internal` flag and add `@final` to `ServicesResetter`
- * Add log_channel in `ErrorListener`
- * Add a new logging channel for exceptions to provide better granularity and control over exception logging.
- * Allow configuring the logging channel per type of exceptions in ErrorListener
+
 
 7.1
 ---
diff --git a/src/Symfony/Component/HttpKernel/Tests/EventListener/ErrorListenerTest.php b/src/Symfony/Component/HttpKernel/Tests/EventListener/ErrorListenerTest.php
@@ -161,7 +161,7 @@ public function testHandleWithLogChannel()
                 'log_level' => 'error',
                 'status_code' => 402,
             ],
-        ], ['channel' => $channelLoger,]);
+        ], ['channel' => $channelLoger]);
 
         $l->logKernelException($event);
         $l->onKernelException($event);
@@ -189,7 +189,7 @@ public function testHandleWithLoggerChannelNotUsed()
                 'status_code' => 402,
                 'log_channel' => 'channel',
             ],
-        ], ['channel' => $channelLoger,]);
+        ], ['channel' => $channelLoger]);
         $l->logKernelException($event);
         $l->onKernelException($event);
 

Original file line number	Diff line number	Diff line change
`@@ -421,8 +421,8 @@ public function load(array $configs, ContainerBuilder $container): void`
`421`	`421`	`}`
`422`	`422`
`423`	`423`	`$exceptionListener`
`424`		`- ->replaceArgument(3, $config['exceptions'])`
`425`		`- ->replaceArgument(4, $loggers)`
	`424`	`+ ->setArgument(3, $config['exceptions'])`
	`425`	`+ ->setArgument(4, $loggers)`
`426`	`426`	`;`
`427`	`427`
`428`	`428`	`if ($this->readConfigEnabled('serializer', $container, $config['serializer'])) {`