[DependencyInjection] Forbid container cloning

jakzal · jakzal · commit df5f4ec7fcd3 · 2015-07-16T09:25:41.000+01:00
diff --git a/src/Symfony/Component/DependencyInjection/Container.php b/src/Symfony/Component/DependencyInjection/Container.php
@@ -90,6 +90,11 @@ public function __construct(ParameterBagInterface $parameterBag = null)
         $this->parameterBag = $parameterBag ?: new ParameterBag();
     }
 
+    public function __clone()
+    {
+        throw new \LogicException('Cloning the container is not supported');
+    }
+
     /**
      * Compiles the container.
      *
diff --git a/src/Symfony/Component/DependencyInjection/Tests/ContainerTest.php b/src/Symfony/Component/DependencyInjection/Tests/ContainerTest.php
@@ -662,6 +662,16 @@ public function testAlias()
         $this->assertTrue($c->has('alias'));
         $this->assertSame($c->get('alias'), $c->get('bar'));
     }
+
+    /**
+     * @expectedException LogicException
+     */
+    public function testThatCloningIsNotSupported()
+    {
+        $c = new Container();
+
+        clone $c;
+    }
 }
 
 class ProjectServiceContainer extends Container

Original file line number	Diff line number	Diff line change
`@@ -90,6 +90,11 @@ public function __construct(ParameterBagInterface $parameterBag = null)`
`90`	`90`	`$this->parameterBag = $parameterBag ?: new ParameterBag();`
`91`	`91`	`}`
`92`	`92`
	`93`	`+ public function __clone()`
	`94`	`+ {`
	`95`	`+ throw new \LogicException('Cloning the container is not supported');`
	`96`	`+ }`
	`97`	`+`
`93`	`98`	`/**`
`94`	`99`	`* Compiles the container.`
`95`	`100`	`*`