feature #27168 [HttpKernel] Add Kernel::getAnnotatedClassesToCompile() (nicolas-grekas)

fabpot · fabpot · commit df0296934d00 · 2018-05-07T11:18:05.000+02:00
This PR was merged into the 4.1-dev branch. Discussion ---------- [HttpKernel] Add Kernel::getAnnotatedClassesToCompile() | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Now that apps are usually bundle-less, we're missing a way to defined the classes to parse annotations for. Here is a PR fixing this by allowing ppl to define a new `getAnnotatedClassesToCompile()` on their kernel when needed. Commits ------- 1d2a49a [HttpKernel] Add Kernel::getAnnotatedClassesToCompile()
diff --git a/src/Symfony/Component/HttpKernel/DependencyInjection/AddAnnotatedClassesToCachePass.php b/src/Symfony/Component/HttpKernel/DependencyInjection/AddAnnotatedClassesToCachePass.php
@@ -36,7 +36,7 @@ public function __construct(Kernel $kernel)
      */
     public function process(ContainerBuilder $container)
     {
-        $annotatedClasses = array();
+        $annotatedClasses = $this->kernel->getAnnotatedClassesToCompile();
         foreach ($container->getExtensions() as $extension) {
             if ($extension instanceof Extension) {
                 $annotatedClasses = array_merge($annotatedClasses, $extension->getAnnotatedClassesToCompile());
diff --git a/src/Symfony/Component/HttpKernel/Kernel.php b/src/Symfony/Component/HttpKernel/Kernel.php
@@ -391,6 +391,14 @@ public function getCharset()
         return 'UTF-8';
     }
 
+    /**
+     * Gets the patterns defining the classes to parse and cache for annotations.
+     */
+    public function getAnnotatedClassesToCompile(): array
+    {
+        return array();
+    }
+
     /**
      * Initializes bundles.
      *

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ public function __construct(Kernel $kernel)`
`36`	`36`	`*/`
`37`	`37`	`public function process(ContainerBuilder $container)`
`38`	`38`	`{`
`39`		`- $annotatedClasses = array();`
	`39`	`+ $annotatedClasses = $this->kernel->getAnnotatedClassesToCompile();`
`40`	`40`	`foreach ($container->getExtensions() as $extension) {`
`41`	`41`	`if ($extension instanceof Extension) {`
`42`	`42`	`$annotatedClasses = array_merge($annotatedClasses, $extension->getAnnotatedClassesToCompile());`
Original file line number	Diff line number	Diff line change
`@@ -391,6 +391,14 @@ public function getCharset()`
`391`	`391`	`return 'UTF-8';`
`392`	`392`	`}`
`393`	`393`
	`394`	`+ /**`
	`395`	`+ * Gets the patterns defining the classes to parse and cache for annotations.`
	`396`	`+ */`
	`397`	`+ public function getAnnotatedClassesToCompile(): array`
	`398`	`+ {`
	`399`	`+ return array();`
	`400`	`+ }`
	`401`	`+`
`394`	`402`	`/**`
`395`	`403`	`* Initializes bundles.`
`396`	`404`	`*`