bug #39896 [PropertyInfo] Fix breaking change with has*(arguments...) methods (YaFou)

xabbuh · xabbuh · commit de8ddfdfba57 · 2021-01-22T18:02:52.000+01:00
This PR was merged into the 5.1 branch. Discussion ---------- [PropertyInfo] Fix breaking change with has*(arguments...) methods | Q | A | ------------- | --- | Branch? | 5.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #39885 | License | MIT | Doc PR | symfony/symfony-docs#...   Until 5.0: ```php class Dummy { private $elements; public function hasElement($element): bool { // ... } } $extractor = new ReflectionExtractor(); $extractor->isReadable('Dummy', 'element'); // false ``` After 5.0: ```php class Dummy { private $elements; public function hasElement($element): bool { // ... } } $extractor = new ReflectionExtractor(); $extractor->isReadable('Dummy', 'element'); // true => BREAKING CHANGE ``` Commits ------- 37cc16e [PropertyInfo] Fix breaking change with has*(arguments...) methods
diff --git a/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php b/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php
@@ -239,7 +239,7 @@ public function getReadInfo(string $class, string $property, array $context = []
         foreach ($this->accessorPrefixes as $prefix) {
             $methodName = $prefix.$camelProp;
 
-            if ($reflClass->hasMethod($methodName) && ($reflClass->getMethod($methodName)->getModifiers() & $this->methodReflectionFlags)) {
+            if ($reflClass->hasMethod($methodName) && $reflClass->getMethod($methodName)->getModifiers() & $this->methodReflectionFlags && !$reflClass->getMethod($methodName)->getNumberOfRequiredParameters()) {
                 $method = $reflClass->getMethod($methodName);
 
                 return new PropertyReadInfo(PropertyReadInfo::TYPE_METHOD, $methodName, $this->getReadVisiblityForMethod($method), $method->isStatic(), false);
diff --git a/src/Symfony/Component/PropertyInfo/Tests/Extractor/ReflectionExtractorTest.php b/src/Symfony/Component/PropertyInfo/Tests/Extractor/ReflectionExtractorTest.php
@@ -75,6 +75,7 @@ public function testGetProperties()
                 'xTotals',
                 'YT',
                 'date',
+                'element',
                 'c',
                 'd',
                 'e',
@@ -291,6 +292,7 @@ public function getReadableProperties()
             ['id', true],
             ['Guid', true],
             ['guid', false],
+            ['element', false],
         ];
     }
 
diff --git a/src/Symfony/Component/PropertyInfo/Tests/Fixtures/Dummy.php b/src/Symfony/Component/PropertyInfo/Tests/Fixtures/Dummy.php
@@ -130,6 +130,8 @@ class Dummy extends ParentDummy
      */
     public $nestedIterators;
 
+    private $elements;
+
     public static function getStatic()
     {
     }
@@ -218,4 +220,8 @@ public function setDate(\DateTime $date)
     public function addDate(\DateTime $date)
     {
     }
+
+    public function hasElement(string $element): bool
+    {
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -130,6 +130,8 @@ class Dummy extends ParentDummy`
`130`	`130`	`*/`
`131`	`131`	`public $nestedIterators;`
`132`	`132`
	`133`	`+ private $elements;`
	`134`	`+`
`133`	`135`	`public static function getStatic()`
`134`	`136`	`{`
`135`	`137`	`}`
`@@ -218,4 +220,8 @@ public function setDate(\DateTime $date)`
`218`	`220`	`public function addDate(\DateTime $date)`
`219`	`221`	`{`
`220`	`222`	`}`
	`223`	`+`
	`224`	`+ public function hasElement(string $element): bool`
	`225`	`+ {`
	`226`	`+ }`
`221`	`227`	`}`