[Serializer] forward the context from the JsonEncoder to JsonEncode and JsonDecode

dbu · nicolas-grekas · commit d8cf930b0a42 · 2022-09-29T11:22:22.000+02:00
diff --git a/src/Symfony/Component/Serializer/Encoder/JsonEncoder.php b/src/Symfony/Component/Serializer/Encoder/JsonEncoder.php
@@ -23,17 +23,24 @@ class JsonEncoder implements EncoderInterface, DecoderInterface
     protected $encodingImpl;
     protected $decodingImpl;
 
+    private $defaultContext = [
+        JsonDecode::ASSOCIATIVE => true,
+    ];
+
     public function __construct(JsonEncode $encodingImpl = null, JsonDecode $decodingImpl = null, array $defaultContext = [])
     {
-        $this->encodingImpl = $encodingImpl ?? new JsonEncode($defaultContext);
-        $this->decodingImpl = $decodingImpl ?? new JsonDecode(array_merge([JsonDecode::ASSOCIATIVE => true], $defaultContext));
+        $this->defaultContext = array_merge($this->defaultContext, $defaultContext);
+        $this->encodingImpl = $encodingImpl ?? new JsonEncode($this->defaultContext);
+        $this->decodingImpl = $decodingImpl ?? new JsonDecode($this->defaultContext);
     }
 
     /**
      * {@inheritdoc}
      */
     public function encode($data, string $format, array $context = [])
     {
+        $context = array_merge($this->defaultContext, $context);
+
         return $this->encodingImpl->encode($data, self::FORMAT, $context);
     }
 
@@ -42,6 +49,8 @@ public function encode($data, string $format, array $context = [])
      */
     public function decode(string $data, string $format, array $context = [])
     {
+        $context = array_merge($this->defaultContext, $context);
+
         return $this->decodingImpl->decode($data, self::FORMAT, $context);
     }
 
diff --git a/src/Symfony/Component/Serializer/Encoder/YamlEncoder.php b/src/Symfony/Component/Serializer/Encoder/YamlEncoder.php
@@ -28,7 +28,17 @@ class YamlEncoder implements EncoderInterface, DecoderInterface
 
     public const PRESERVE_EMPTY_OBJECTS = 'preserve_empty_objects';
 
+    /**
+     * Override the amount of spaces to use for indentation of nested nodes.
+     *
+     * This option only works in the constructor, not in calls to `encode`.
+     */
+    public const YAML_INDENTATION = 'yaml_indentation';
+
     public const YAML_INLINE = 'yaml_inline';
+    /**
+     * Initial indentation for root element.
+     */
     public const YAML_INDENT = 'yaml_indent';
     public const YAML_FLAGS = 'yaml_flags';
 
@@ -46,8 +56,12 @@ public function __construct(Dumper $dumper = null, Parser $parser = null, array
             throw new RuntimeException('The YamlEncoder class requires the "Yaml" component. Install "symfony/yaml" to use it.');
         }
 
-        $this->dumper = $dumper ?? new Dumper();
+        if (!$dumper) {
+            $dumper = \array_key_exists(self::YAML_INDENTATION, $defaultContext) ? new Dumper($defaultContext[self::YAML_INDENTATION]) : new Dumper();
+        }
+        $this->dumper = $dumper;
         $this->parser = $parser ?? new Parser();
+        unset($defaultContext[self::YAML_INDENTATION]);
         $this->defaultContext = array_merge($this->defaultContext, $defaultContext);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -23,17 +23,24 @@ class JsonEncoder implements EncoderInterface, DecoderInterface`
`23`	`23`	`protected $encodingImpl;`
`24`	`24`	`protected $decodingImpl;`
`25`	`25`
	`26`	`+ private $defaultContext = [`
	`27`	`+ JsonDecode::ASSOCIATIVE => true,`
	`28`	`+ ];`
	`29`	`+`
`26`	`30`	`public function __construct(JsonEncode $encodingImpl = null, JsonDecode $decodingImpl = null, array $defaultContext = [])`
`27`	`31`	`{`
`28`		`- $this->encodingImpl = $encodingImpl ?? new JsonEncode($defaultContext);`
`29`		`- $this->decodingImpl = $decodingImpl ?? new JsonDecode(array_merge([JsonDecode::ASSOCIATIVE => true], $defaultContext));`
	`32`	`+ $this->defaultContext = array_merge($this->defaultContext, $defaultContext);`
	`33`	`+ $this->encodingImpl = $encodingImpl ?? new JsonEncode($this->defaultContext);`
	`34`	`+ $this->decodingImpl = $decodingImpl ?? new JsonDecode($this->defaultContext);`
`30`	`35`	`}`
`31`	`36`
`32`	`37`	`/**`
`33`	`38`	`* {@inheritdoc}`
`34`	`39`	`*/`
`35`	`40`	`public function encode($data, string $format, array $context = [])`
`36`	`41`	`{`
	`42`	`+ $context = array_merge($this->defaultContext, $context);`
	`43`	`+`
`37`	`44`	`return $this->encodingImpl->encode($data, self::FORMAT, $context);`
`38`	`45`	`}`
`39`	`46`
`@@ -42,6 +49,8 @@ public function encode($data, string $format, array $context = [])`
`42`	`49`	`*/`
`43`	`50`	`public function decode(string $data, string $format, array $context = [])`
`44`	`51`	`{`
	`52`	`+ $context = array_merge($this->defaultContext, $context);`
	`53`	`+`
`45`	`54`	`return $this->decodingImpl->decode($data, self::FORMAT, $context);`
`46`	`55`	`}`
`47`	`56`