Resolve PR comments

bobvandevijver · bobvandevijver · commit d896b3aa0a9d · 2025-08-01T13:00:23.000+02:00
diff --git a/src/Symfony/Component/Mailer/Bridge/MicrosoftGraph/Transport/MicrosoftGraphApiTransport.php b/src/Symfony/Component/Mailer/Bridge/MicrosoftGraph/Transport/MicrosoftGraphApiTransport.php
@@ -26,7 +26,7 @@
 
 class MicrosoftGraphApiTransport extends AbstractApiTransport
 {
-    private const userEndpoint = '/v1.0/users/%s/sendMail';
+    private const USER_ENDPOINT = '/v1.0/users/%s/sendMail';
 
     /**
      * @param string $graphEndpoint Graph API URL to which to POST emails
@@ -50,7 +50,7 @@ public function __toString(): string
 
     protected function doSendApi(SentMessage $sentMessage, Email $email, Envelope $envelope): ResponseInterface
     {
-        $endpoint = "https://$this->graphEndpoint".\sprintf(self::userEndpoint, $envelope->getSender()->getAddress());
+        $endpoint = "https://$this->graphEndpoint".\sprintf(self::USER_ENDPOINT, $envelope->getSender()->getAddress());
         $payload = $this->getPayload($email, $envelope);
 
         $response = $this->client->request('POST', $endpoint, [
diff --git a/src/Symfony/Component/Mailer/Bridge/MicrosoftGraph/Transport/MicrosoftGraphTransportFactory.php b/src/Symfony/Component/Mailer/Bridge/MicrosoftGraph/Transport/MicrosoftGraphTransportFactory.php
@@ -44,23 +44,9 @@ public function create(Dsn $dsn): TransportInterface
             throw new IncompleteDsnException("Transport 'microsoft+graphapi' requires the 'authEndpoint' option when not using the default graph endpoint.");
         }
 
-        $tokenManager = new TokenManager(
-            $graphEndpoint,
-            $authEndpoint,
-            $tenantId,
-            $this->getUser($dsn),
-            $this->getPassword($dsn),
-            $this->client,
-        );
+        $tokenManager = new TokenManager($graphEndpoint, $authEndpoint, $tenantId, $this->getUser($dsn), $this->getPassword($dsn), $this->client);
 
-        return new MicrosoftGraphApiTransport(
-            $graphEndpoint,
-            $tokenManager,
-            $dsn->getBooleanOption('noSave'),
-            $this->client,
-            $this->dispatcher,
-            $this->logger,
-        );
+        return new MicrosoftGraphApiTransport($graphEndpoint, $tokenManager, $dsn->getBooleanOption('noSave'), $this->client, $this->dispatcher, $this->logger);
     }
 
     protected function getSupportedSchemes(): array
diff --git a/src/Symfony/Component/Mailer/Bridge/MicrosoftGraph/composer.json b/src/Symfony/Component/Mailer/Bridge/MicrosoftGraph/composer.json
@@ -26,11 +26,9 @@
     "require": {
         "php": ">=8.2",
         "symfony/clock": "^7.4|^8.0",
+        "symfony/http-client": "^6.4|^7.0|^8.0",
         "symfony/mailer": "^7.4|^8.0"
     },
-    "require-dev": {
-        "symfony/http-client": "^6.4|^7.0|^8.0"
-    },
     "autoload": {
         "psr-4": { "Symfony\\Component\\Mailer\\Bridge\\MicrosoftGraph\\": "" },
         "exclude-from-classmap": [

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@`
`26`	`26`
`27`	`27`	`class MicrosoftGraphApiTransport extends AbstractApiTransport`
`28`	`28`	`{`
`29`		`- private const userEndpoint = '/v1.0/users/%s/sendMail';`
	`29`	`+ private const USER_ENDPOINT = '/v1.0/users/%s/sendMail';`
`30`	`30`
`31`	`31`	`/**`
`32`	`32`	`* @param string $graphEndpoint Graph API URL to which to POST emails`
`@@ -50,7 +50,7 @@ public function __toString(): string`
`50`	`50`
`51`	`51`	`protected function doSendApi(SentMessage $sentMessage, Email $email, Envelope $envelope): ResponseInterface`
`52`	`52`	`{`
`53`		`- $endpoint = "https://$this->graphEndpoint".\sprintf(self::userEndpoint, $envelope->getSender()->getAddress());`
	`53`	`+ $endpoint = "https://$this->graphEndpoint".\sprintf(self::USER_ENDPOINT, $envelope->getSender()->getAddress());`
`54`	`54`	`$payload = $this->getPayload($email, $envelope);`
`55`	`55`
`56`	`56`	`$response = $this->client->request('POST', $endpoint, [`