Introduce NullMessage and remove transport setter in MessageInterface

jschaedl · jschaedl · commit d2bc94317d27 · 2020-10-07T22:04:37.000+02:00
diff --git a/src/Symfony/Component/Notifier/Message/ChatMessage.php b/src/Symfony/Component/Notifier/Message/ChatMessage.php
@@ -77,7 +77,7 @@ public function getOptions(): ?MessageOptionsInterface
     /**
      * @return $this
      */
-    public function transport(?string $transport): MessageInterface
+    public function transport(?string $transport): self
     {
         $this->transport = $transport;
 
diff --git a/src/Symfony/Component/Notifier/Message/EmailMessage.php b/src/Symfony/Component/Notifier/Message/EmailMessage.php
@@ -102,7 +102,7 @@ public function getOptions(): ?MessageOptionsInterface
     /**
      * @return $this
      */
-    public function transport(string $transport): MessageInterface
+    public function transport(string $transport): self
     {
         if (!$this->message instanceof Email) {
             throw new LogicException('Cannot set a Transport on a RawMessage instance.');
diff --git a/src/Symfony/Component/Notifier/Message/MessageInterface.php b/src/Symfony/Component/Notifier/Message/MessageInterface.php
@@ -25,6 +25,4 @@ public function getSubject(): string;
     public function getOptions(): ?MessageOptionsInterface;
 
     public function getTransport(): ?string;
-
-    public function transport(string $transport): self;
 }
diff --git a/src/Symfony/Component/Notifier/Message/NullMessage.php b/src/Symfony/Component/Notifier/Message/NullMessage.php
@@ -0,0 +1,44 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+declare(strict_types=1);
+
+namespace Symfony\Component\Notifier\Message;
+
+final class NullMessage implements MessageInterface
+{
+    private $decoratedMessage;
+
+    public function __construct(MessageInterface $message)
+    {
+        $this->decoratedMessage = $message;
+    }
+
+    public function getRecipientId(): ?string
+    {
+        return $this->decoratedMessage->getRecipientId();
+    }
+
+    public function getSubject(): string
+    {
+        return $this->decoratedMessage->getSubject();
+    }
+
+    public function getOptions(): ?MessageOptionsInterface
+    {
+        return $this->decoratedMessage->getOptions();
+    }
+
+    public function getTransport(): ?string
+    {
+        return $this->decoratedMessage->getTransport() ?? 'null';
+    }
+}
diff --git a/src/Symfony/Component/Notifier/Message/SmsMessage.php b/src/Symfony/Component/Notifier/Message/SmsMessage.php
@@ -83,7 +83,7 @@ public function getSubject(): string
     /**
      * @return $this
      */
-    public function transport(string $transport): MessageInterface
+    public function transport(string $transport): self
     {
         $this->transport = $transport;
 
diff --git a/src/Symfony/Component/Notifier/Transport/NullTransport.php b/src/Symfony/Component/Notifier/Transport/NullTransport.php
@@ -15,6 +15,7 @@
 use Symfony\Component\EventDispatcher\LegacyEventDispatcherProxy;
 use Symfony\Component\Notifier\Event\MessageEvent;
 use Symfony\Component\Notifier\Message\MessageInterface;
+use Symfony\Component\Notifier\Message\NullMessage;
 use Symfony\Component\Notifier\Message\SentMessage;
 use Symfony\Contracts\EventDispatcher\EventDispatcherInterface;
 
@@ -34,9 +35,7 @@ public function __construct(EventDispatcherInterface $dispatcher = null)
 
     public function send(MessageInterface $message): SentMessage
     {
-        if (null === $message->getTransport()) {
-            $message->transport((string) $this);
-        }
+        $message = new NullMessage($message);
 
         if (null !== $this->dispatcher) {
             $this->dispatcher->dispatch(new MessageEvent($message));
diff --git a/src/Symfony/Component/Notifier/Transport/Transports.php b/src/Symfony/Component/Notifier/Transport/Transports.php
@@ -57,8 +57,6 @@ public function send(MessageInterface $message): SentMessage
         if (!$transport = $message->getTransport()) {
             foreach ($this->transports as $transportName => $transport) {
                 if ($transport->supports($message)) {
-                    $message->transport($transportName);
-
                     return $transport->send($message);
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,7 @@ public function getOptions(): ?MessageOptionsInterface`
`77`	`77`	`/**`
`78`	`78`	`* @return $this`
`79`	`79`	`*/`
`80`		`- public function transport(?string $transport): MessageInterface`
	`80`	`+ public function transport(?string $transport): self`
`81`	`81`	`{`
`82`	`82`	`$this->transport = $transport;`
`83`	`83`
Original file line number	Diff line number	Diff line change
`@@ -102,7 +102,7 @@ public function getOptions(): ?MessageOptionsInterface`
`102`	`102`	`/**`
`103`	`103`	`* @return $this`
`104`	`104`	`*/`
`105`		`- public function transport(string $transport): MessageInterface`
	`105`	`+ public function transport(string $transport): self`
`106`	`106`	`{`
`107`	`107`	`if (!$this->message instanceof Email) {`
`108`	`108`	`throw new LogicException('Cannot set a Transport on a RawMessage instance.');`
Original file line number	Diff line number	Diff line change
`@@ -25,6 +25,4 @@ public function getSubject(): string;`
`25`	`25`	`public function getOptions(): ?MessageOptionsInterface;`
`26`	`26`
`27`	`27`	`public function getTransport(): ?string;`
`28`		`-`
`29`		`- public function transport(string $transport): self;`
`30`	`28`	`}`
Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ public function getSubject(): string`
`83`	`83`	`/**`
`84`	`84`	`* @return $this`
`85`	`85`	`*/`
`86`		`- public function transport(string $transport): MessageInterface`
	`86`	`+ public function transport(string $transport): self`
`87`	`87`	`{`
`88`	`88`	`$this->transport = $transport;`
`89`	`89`
Original file line number	Diff line number	Diff line change
`@@ -57,8 +57,6 @@ public function send(MessageInterface $message): SentMessage`
`57`	`57`	`if (!$transport = $message->getTransport()) {`
`58`	`58`	`foreach ($this->transports as $transportName => $transport) {`
`59`	`59`	`if ($transport->supports($message)) {`
`60`		`- $message->transport($transportName);`
`61`		`-`
`62`	`60`	`return $transport->send($message);`
`63`	`61`	`}`
`64`	`62`	`}`