feature #18676 [HttpKernel] Add request method to logger messages (gnat42)

fabpot · fabpot · commit d02e5eb6a1c8 · 2016-05-13T10:12:29.000-05:00
This PR was merged into the 3.1-dev branch. Discussion ---------- [HttpKernel] Add request method to logger messages | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | While debugging some functional tests I was looking at the test.log. It would have been quite useful to know if the request was a POST or GET. This adds the request method to the log details. Commits ------- d751d59 Add request method to logger messages
diff --git a/src/Symfony/Component/HttpKernel/EventListener/RouterListener.php b/src/Symfony/Component/HttpKernel/EventListener/RouterListener.php
@@ -108,6 +108,7 @@ public function onKernelRequest(GetResponseEvent $event)
                     'route' => isset($parameters['_route']) ? $parameters['_route'] : 'n/a',
                     'route_parameters' => $parameters,
                     'request_uri' => $request->getUri(),
+                    'method' => $request->getMethod(),
                 ));
             }
 
diff --git a/src/Symfony/Component/HttpKernel/Tests/EventListener/RouterListenerTest.php b/src/Symfony/Component/HttpKernel/Tests/EventListener/RouterListenerTest.php
@@ -150,8 +150,8 @@ public function testLoggingParameter($parameter, $log, $parameters)
     public function getLoggingParameterData()
     {
         return array(
-            array(array('_route' => 'foo'), 'Matched route "{route}".', array('route' => 'foo', 'route_parameters' => array('_route' => 'foo'), 'request_uri' => 'http://localhost/')),
-            array(array(), 'Matched route "{route}".', array('route' => 'n/a', 'route_parameters' => array(), 'request_uri' => 'http://localhost/')),
+            array(array('_route' => 'foo'), 'Matched route "{route}".', array('route' => 'foo', 'route_parameters' => array('_route' => 'foo'), 'request_uri' => 'http://localhost/', 'method' => 'GET')),
+            array(array(), 'Matched route "{route}".', array('route' => 'n/a', 'route_parameters' => array(), 'request_uri' => 'http://localhost/', 'method' => 'GET')),
         );
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -108,6 +108,7 @@ public function onKernelRequest(GetResponseEvent $event)`
`108`	`108`	`'route' => isset($parameters['_route']) ? $parameters['_route'] : 'n/a',`
`109`	`109`	`'route_parameters' => $parameters,`
`110`	`110`	`'request_uri' => $request->getUri(),`
	`111`	`+ 'method' => $request->getMethod(),`
`111`	`112`	`));`
`112`	`113`	`}`
`113`	`114`
Original file line number	Diff line number	Diff line change
`@@ -150,8 +150,8 @@ public function testLoggingParameter($parameter, $log, $parameters)`
`150`	`150`	`public function getLoggingParameterData()`
`151`	`151`	`{`
`152`	`152`	`return array(`
`153`		`- array(array('_route' => 'foo'), 'Matched route "{route}".', array('route' => 'foo', 'route_parameters' => array('_route' => 'foo'), 'request_uri' => 'http://localhost/')),`
`154`		`- array(array(), 'Matched route "{route}".', array('route' => 'n/a', 'route_parameters' => array(), 'request_uri' => 'http://localhost/')),`
	`153`	`+ array(array('_route' => 'foo'), 'Matched route "{route}".', array('route' => 'foo', 'route_parameters' => array('_route' => 'foo'), 'request_uri' => 'http://localhost/', 'method' => 'GET')),`
	`154`	`+ array(array(), 'Matched route "{route}".', array('route' => 'n/a', 'route_parameters' => array(), 'request_uri' => 'http://localhost/', 'method' => 'GET')),`
`155`	`155`	`);`
`156`	`156`	`}`
`157`	`157`	`}`