[Config] Changes after code review

jschaedl · jschaedl · commit cf049b55bca4 · 2019-06-11T20:52:27.000+02:00
diff --git a/src/Symfony/Component/Config/Definition/Builder/ArrayNodeDefinition.php b/src/Symfony/Component/Config/Definition/Builder/ArrayNodeDefinition.php
@@ -536,7 +536,7 @@ public function find(string $nodePath): NodeDefinition
             : substr($nodePath, 0, $pathSeparatorPos);
 
         if (null === $node = ($this->children[$firstPathSegment] ?? null)) {
-            throw new \RuntimeException(sprintf('Node with name "%s" does not exist in the current node "%s"!', $firstPathSegment, $this->name));
+            throw new \RuntimeException(sprintf('Node with name "%s" does not exist in the current node "%s".', $firstPathSegment, $this->name));
         }
 
         if (false === $pathSeparatorPos) {
diff --git a/src/Symfony/Component/Config/Tests/Definition/Builder/ArrayNodeDefinitionTest.php b/src/Symfony/Component/Config/Tests/Definition/Builder/ArrayNodeDefinitionTest.php
@@ -362,7 +362,7 @@ public function testCannotBeEmptyOnConcreteNode()
     public function testFindShouldThrowExceptionIfNodeDoesNotExistInRootNode()
     {
         $this->expectException(\RuntimeException::class);
-        $this->expectExceptionMessage('Node with name "child" does not exist in the current node "root"!');
+        $this->expectExceptionMessage('Node with name "child" does not exist in the current node "root".');
 
         $rootNode = new ArrayNodeDefinition('root');
         $rootNode
@@ -374,7 +374,7 @@ public function testFindShouldThrowExceptionIfNodeDoesNotExistInRootNode()
         $rootNode->find('child');
     }
 
-    public function testFindShouldHandleComplexConfigurationProbably()
+    public function testFindShouldHandleComplexConfigurationProperly()
     {
         $rootNode = new ArrayNodeDefinition('root');
         $rootNode
@@ -413,7 +413,7 @@ public function testFindShouldHandleComplexConfigurationProbably()
         $this->assertNode('transports', ArrayNodeDefinition::class, $mailerNode->find('transports'));
     }
 
-    public function testFindShouldWorkProbablyForNonDefaultPathSeparator()
+    public function testFindShouldWorkProperlyForNonDefaultPathSeparator()
     {
         $rootNode = new ArrayNodeDefinition('root');
         $rootNode

Original file line number	Diff line number	Diff line change
`@@ -536,7 +536,7 @@ public function find(string $nodePath): NodeDefinition`
`536`	`536`	`: substr($nodePath, 0, $pathSeparatorPos);`
`537`	`537`
`538`	`538`	`if (null === $node = ($this->children[$firstPathSegment] ?? null)) {`
`539`		`- throw new \RuntimeException(sprintf('Node with name "%s" does not exist in the current node "%s"!', $firstPathSegment, $this->name));`
	`539`	`+ throw new \RuntimeException(sprintf('Node with name "%s" does not exist in the current node "%s".', $firstPathSegment, $this->name));`
`540`	`540`	`}`
`541`	`541`
`542`	`542`	`if (false === $pathSeparatorPos) {`
Original file line number	Diff line number	Diff line change
`@@ -362,7 +362,7 @@ public function testCannotBeEmptyOnConcreteNode()`
`362`	`362`	`public function testFindShouldThrowExceptionIfNodeDoesNotExistInRootNode()`
`363`	`363`	`{`
`364`	`364`	`$this->expectException(\RuntimeException::class);`
`365`		`- $this->expectExceptionMessage('Node with name "child" does not exist in the current node "root"!');`
	`365`	`+ $this->expectExceptionMessage('Node with name "child" does not exist in the current node "root".');`
`366`	`366`
`367`	`367`	`$rootNode = new ArrayNodeDefinition('root');`
`368`	`368`	`$rootNode`
`@@ -374,7 +374,7 @@ public function testFindShouldThrowExceptionIfNodeDoesNotExistInRootNode()`
`374`	`374`	`$rootNode->find('child');`
`375`	`375`	`}`
`376`	`376`
`377`		`- public function testFindShouldHandleComplexConfigurationProbably()`
	`377`	`+ public function testFindShouldHandleComplexConfigurationProperly()`
`378`	`378`	`{`
`379`	`379`	`$rootNode = new ArrayNodeDefinition('root');`
`380`	`380`	`$rootNode`
`@@ -413,7 +413,7 @@ public function testFindShouldHandleComplexConfigurationProbably()`
`413`	`413`	`$this->assertNode('transports', ArrayNodeDefinition::class, $mailerNode->find('transports'));`
`414`	`414`	`}`
`415`	`415`
`416`		`- public function testFindShouldWorkProbablyForNonDefaultPathSeparator()`
	`416`	`+ public function testFindShouldWorkProperlyForNonDefaultPathSeparator()`
`417`	`417`	`{`
`418`	`418`	`$rootNode = new ArrayNodeDefinition('root');`
`419`	`419`	`$rootNode`