fix: loading of WebProfilerBundle’s toolbar stylesheet

alexislefebvre · alexislefebvre · commit cc2bb9a78e79 · 2024-12-16T19:24:02.000+01:00
diff --git a/src/Symfony/Bundle/WebProfilerBundle/Resources/config/routing/wdt.xml b/src/Symfony/Bundle/WebProfilerBundle/Resources/config/routing/wdt.xml
@@ -4,7 +4,8 @@
     xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
     xsi:schemaLocation="http://symfony.com/schema/routing https://symfony.com/schema/routing/routing-1.0.xsd">
 
-    <route id="_wdt_stylesheet" path="/styles.css">
+    <!-- Using a path like “…/styles.css” cause issues with some web servers which try to fetch the file, and fail to do it -->
+    <route id="_wdt_stylesheet" path="/styles-css">
         <default key="_controller">web_profiler.controller.profiler::toolbarStylesheetAction</default>
     </route>
 
diff --git a/src/Symfony/Bundle/WebProfilerBundle/Tests/Controller/ProfilerControllerTest.php b/src/Symfony/Bundle/WebProfilerBundle/Tests/Controller/ProfilerControllerTest.php
@@ -164,6 +164,20 @@ public function testToolbarStylesheetAction()
         $this->assertSame('max-age=600, private', $response->headers->get('Cache-Control'));
     }
 
+    public function testToolbarStylesheetActionFromPath()
+    {
+        $kernel = new WebProfilerBundleKernel();
+        $client = new KernelBrowser($kernel);
+
+        $client->request('GET', '/_wdt/styles-css');
+
+        $response = $client->getResponse();
+
+        $this->assertSame(200, $response->getStatusCode());
+        $this->assertSame('text/css; charset=UTF-8', $response->headers->get('Content-Type'));
+        $this->assertSame('max-age=600, private', $response->headers->get('Cache-Control'));
+    }
+
     public static function getEmptyTokenCases()
     {
         return [
