Test AuthenticatorManagers are injected traceable authenticators in debug mode

MatTheCat · MatTheCat · commit c9c19ab3b28f · 2024-12-29T16:36:52.000+01:00
diff --git a/src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/SecurityExtensionTest.php b/src/Symfony/Bundle/SecurityBundle/Tests/DependencyInjection/SecurityExtensionTest.php
@@ -902,7 +902,7 @@ public function testCustomHasherWithMigrateFrom()
         ]);
     }
 
-    public function testAuthenticatorsStillExistAfterBeingDecorated()
+    public function testAuthenticatorsDecoration()
     {
         $container = $this->getRawContainer();
         $container->setParameter('kernel.debug', true);
@@ -918,7 +918,12 @@ public function testAuthenticatorsStillExistAfterBeingDecorated()
         ]);
         $container->compile();
 
-        $this->assertTrue($container->hasDefinition(TestAuthenticator::class));
+        /** @var Reference[] $managerAuthenticators */
+        $managerAuthenticators = $container->getDefinition('security.authenticator.manager.main')->getArgument(0);
+        $this->assertCount(1, $managerAuthenticators);
+        $this->assertSame('debug.'.TestAuthenticator::class, (string) reset($managerAuthenticators), 'AuthenticatorManagers must be injected traceable authenticators in debug mode.');
+
+        $this->assertTrue($container->hasDefinition(TestAuthenticator::class), 'Original authenticator must still exist in the container so it can be used outside of the AuthenticatorManager’s context.');
     }
 
     protected function getRawContainer()

Original file line number	Diff line number	Diff line change
`@@ -902,7 +902,7 @@ public function testCustomHasherWithMigrateFrom()`
`902`	`902`	`]);`
`903`	`903`	`}`
`904`	`904`
`905`		`- public function testAuthenticatorsStillExistAfterBeingDecorated()`
	`905`	`+ public function testAuthenticatorsDecoration()`
`906`	`906`	`{`
`907`	`907`	`$container = $this->getRawContainer();`
`908`	`908`	`$container->setParameter('kernel.debug', true);`
`@@ -918,7 +918,12 @@ public function testAuthenticatorsStillExistAfterBeingDecorated()`
`918`	`918`	`]);`
`919`	`919`	`$container->compile();`
`920`	`920`
`921`		`- $this->assertTrue($container->hasDefinition(TestAuthenticator::class));`
	`921`	`+ /** @var Reference[] $managerAuthenticators */`
	`922`	`+ $managerAuthenticators = $container->getDefinition('security.authenticator.manager.main')->getArgument(0);`
	`923`	`+ $this->assertCount(1, $managerAuthenticators);`
	`924`	`+ $this->assertSame('debug.'.TestAuthenticator::class, (string) reset($managerAuthenticators), 'AuthenticatorManagers must be injected traceable authenticators in debug mode.');`
	`925`	`+`
	`926`	`+ $this->assertTrue($container->hasDefinition(TestAuthenticator::class), 'Original authenticator must still exist in the container so it can be used outside of the AuthenticatorManager’s context.');`
`922`	`927`	`}`
`923`	`928`
`924`	`929`	`protected function getRawContainer()`