bug #47189 [Validator] Add additional hint when egulias/email-validator needs to be installed (mpdude)

fabpot · fabpot · commit c944281e0d7b · 2022-08-05T13:43:56.000+02:00
This PR was merged into the 4.4 branch. Discussion ---------- [Validator] Add additional hint when `egulias/email-validator` needs to be installed | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | When using the `Symfony\Component\Validator\Constraints\Email` constraint with `'mode' => 'strict'`, a helpful error message is shown when the necessary package is not installed. However, when configuring `strict` mode as a framework setting (https://symfony.com/doc/current/reference/configuration/framework.html#email-validation-mode) and omitting the `mode` setting on the constraint itself, that message was missing. Commits ------- 3924498 [Validator] Hint that `egulias/email-validator` needs to be installed for strict mode as default config
diff --git a/src/Symfony/Component/Validator/Constraints/EmailValidator.php b/src/Symfony/Component/Validator/Constraints/EmailValidator.php
@@ -100,6 +100,10 @@ public function validate($value, Constraint $constraint)
         }
 
         if (null === $constraint->mode) {
+            if (Email::VALIDATION_MODE_STRICT === $this->defaultMode && !class_exists(EguliasEmailValidator::class)) {
+                throw new LogicException(sprintf('The "egulias/email-validator" component is required to make the "%s" constraint default to strict mode.', EguliasEmailValidator::class));
+            }
+
             $constraint->mode = $this->defaultMode;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -100,6 +100,10 @@ public function validate($value, Constraint $constraint)`
`100`	`100`	`}`
`101`	`101`
`102`	`102`	`if (null === $constraint->mode) {`
	`103`	`+ if (Email::VALIDATION_MODE_STRICT === $this->defaultMode && !class_exists(EguliasEmailValidator::class)) {`
	`104`	`+ throw new LogicException(sprintf('The "egulias/email-validator" component is required to make the "%s" constraint default to strict mode.', EguliasEmailValidator::class));`
	`105`	`+ }`
	`106`	`+`
`103`	`107`	`$constraint->mode = $this->defaultMode;`
`104`	`108`	`}`
`105`	`109`