bug #47238 [HttpKernel] Fix passing null to \trim() method in LoggerDataCollector (SVillette)

fabpot · fabpot · commit c58f77fe6c20 · 2022-08-10T11:37:01.000+02:00
This PR was squashed before being merged into the 5.4 branch. Discussion ---------- [HttpKernel] Fix passing `null` to `\trim()` method in LoggerDataCollector | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #47235 | License | MIT | Doc PR | - The full explanation of the bug context is described in the [reproducer](https://github.com/SVillette/SymfonyTrimDeprecationReproducer) repository To be short, the fact of logging deprecations in dev environment and accessing the deprecations panel in the profiler triggered a PHP deprecation because the `\trim()` method was called with `null`. Commits ------- b2fea03 [HttpKernel] Fix passing `null` to `\trim()` method in LoggerDataCollector
diff --git a/src/Symfony/Component/HttpKernel/DataCollector/LoggerDataCollector.php b/src/Symfony/Component/HttpKernel/DataCollector/LoggerDataCollector.php
@@ -144,7 +144,7 @@ public function getFilters()
 
         $allChannels = [];
         foreach ($this->getProcessedLogs() as $log) {
-            if ('' === trim($log['channel'])) {
+            if ('' === trim($log['channel'] ?? '')) {
                 continue;
             }
 

Original file line number	Diff line number	Diff line change
`@@ -144,7 +144,7 @@ public function getFilters()`
`144`	`144`
`145`	`145`	`$allChannels = [];`
`146`	`146`	`foreach ($this->getProcessedLogs() as $log) {`
`147`		`- if ('' === trim($log['channel'])) {`
	`147`	`+ if ('' === trim($log['channel'] ?? '')) {`
`148`	`148`	`continue;`
`149`	`149`	`}`
`150`	`150`