Skip to content

Commit c33e9d4

Browse files
nicolas-grekasnicolas-grekas
committed
[HttpKernel] Deprecate __sleep/wakeup() on data collectors and make Profile final
1 parent b130cee commit c33e9d4

File tree

5 files changed

+80
-19
lines changed

5 files changed

+80
-19
lines changed

‎UPGRADE-7.4.md‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,12 @@ HttpFoundation
5252

5353
* Deprecate using `Request::sendHeaders()` after headers have already been sent; use a `StreamedResponse` instead
5454

55+
HttpKernel
56+
----------
57+
58+
* Deprecate implementing `__sleep/wakeup()` on data collectors; use `__(un)serialize()` instead
59+
* Make `Profile` final and `Profiler::__sleep()` internal
60+
5561
Security
5662
--------
5763

‎src/Symfony/Bundle/WebProfilerBundle/Tests/Profiler/TemplateManagerTest.php‎

Lines changed: 15 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,9 @@
1313

1414
use Symfony\Bundle\WebProfilerBundle\Profiler\TemplateManager;
1515
use Symfony\Bundle\WebProfilerBundle\Tests\TestCase;
16+
use Symfony\Component\HttpFoundation\Request;
17+
use Symfony\Component\HttpFoundation\Response;
18+
use Symfony\Component\HttpKernel\DataCollector\DataCollector;
1619
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
1720
use Symfony\Component\HttpKernel\Profiler\Profile;
1821
use Symfony\Component\HttpKernel\Profiler\Profiler;
@@ -57,7 +60,10 @@ public function testGetNameValidTemplate()
5760
->withAnyParameters()
5861
->willReturnCallback($this->profilerHasCallback(...));
5962

60-
$this->assertEquals('@Foo/Collector/foo.html.twig', $this->templateManager->getName(new ProfileDummy(), 'foo'));
63+
$profile = new Profile('token');
64+
$profile->addCollector(new DummyCollector('foo'));
65+
$profile->addCollector(new DummyCollector('bar'));
66+
$this->assertEquals('@Foo/Collector/foo.html.twig', $this->templateManager->getName($profile, 'foo'));
6167
}
6268

6369
public function profilerHasCallback($panel)
@@ -94,19 +100,18 @@ protected function mockTwigEnvironment()
94100
}
95101
}
96102

97-
class ProfileDummy extends Profile
103+
class DummyCollector extends DataCollector
98104
{
99-
public function __construct()
105+
public function __construct(private string $name)
100106
{
101-
parent::__construct('token');
102107
}
103108

104-
public function hasCollector(string $name): bool
109+
public function getName(): string
110+
{
111+
return $this->name;
112+
}
113+
114+
public function collect(Request $request, Response $response, ?\Throwable $exception = null): void
105115
{
106-
return match ($name) {
107-
'foo',
108-
'bar' => true,
109-
default => false,
110-
};
111116
}
112117
}

‎src/Symfony/Component/HttpKernel/CHANGELOG.md‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,12 @@
11
CHANGELOG
22
=========
33

4+
7.4
5+
---
6+
7+
* Deprecate implementing `__sleep/wakeup()` on data collectors; use `__(un)serialize()` instead
8+
* Make `Profile` final and `Profiler::__sleep()` internal
9+
410
7.3
511
---
612

‎src/Symfony/Component/HttpKernel/DataCollector/DataCollector.php‎

Lines changed: 48 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -84,26 +84,67 @@ protected function getCasters(): array
8484
] + ReflectionCaster::UNSET_CLOSURE_FILE_INFO;
8585
}
8686

87-
public function __sleep(): array
87+
public function __serialize(): array
8888
{
89-
return ['data'];
89+
if (self::class === (new \ReflectionMethod($this, '__sleep'))->class) {
90+
return ['data' => $this->data];
91+
}
92+
93+
trigger_deprecation('symfony/http-kernel', '7.4', 'Implementing "%s::__sleep()" is deprecated, use "__serialize()" instead.', get_debug_type($this));
94+
95+
$data = [];
96+
foreach ($this->__sleep() as $key) {
97+
try {
98+
if (($r = new \ReflectionProperty($this, $key))->isInitialized($this)) {
99+
$data[$key] = $r->getValue($this);
100+
}
101+
} catch (\ReflectionException) {
102+
$data[$key] = $this->$key;
103+
}
104+
}
105+
106+
return $data;
90107
}
91108

92-
public function __wakeup(): void
109+
public function __unserialize(array $data): void
93110
{
111+
if (self::class !== (new \ReflectionMethod($this, '__wakeup'))->class) {
112+
trigger_deprecation('symfony/http-kernel', '7.4', 'Implementing "%s::__wakeup()" is deprecated, use "__unserialize()" instead.', get_debug_type($this));
113+
}
114+
115+
if (\in_array(array_keys($data), [['data'], ["\0*\0data"]], true)) {
116+
$this->data = $data['data'] ?? $data["\0*\0data"];
117+
118+
return;
119+
}
120+
121+
trigger_deprecation('symfony/http-kernel', '7.4', 'Passing more than just key "data" to "%s::__unserialize()" is deprecated, populate properties in "%s::__unserialize()" instead.', self::class, get_debug_type($this));
122+
123+
\Closure::bind(function ($data) {
124+
foreach ($data as $key => $value) {
125+
$this->{("\0" === $key[0] ?? '') ? substr($key, 1 + strrpos($key, "\0")) : $key} = $value;
126+
}
127+
128+
$this->__wakeup();
129+
}, $this, static::class)($data);
94130
}
95131

96132
/**
97-
* @internal to prevent implementing \Serializable
133+
* @internal since Symfony 7.4, will be removed in 8.0
134+
*
135+
* @final since Symfony 7.4, will be removed in 8.0
98136
*/
99-
final protected function serialize(): void
137+
public function __sleep(): array
100138
{
139+
return ['data'];
101140
}
102141

103142
/**
104-
* @internal to prevent implementing \Serializable
143+
* @internal since Symfony 7.4, will be removed in 8.0
144+
*
145+
* @final since Symfony 7.4, will be removed in 8.0
105146
*/
106-
final protected function unserialize(string $data): void
147+
public function __wakeup(): void
107148
{
108149
}
109150

‎src/Symfony/Component/HttpKernel/Profiler/Profile.php‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@
1414
use Symfony\Component\HttpKernel\DataCollector\DataCollectorInterface;
1515

1616
/**
17-
* Profile.
18-
*
1917
* @author Fabien Potencier <fabien@symfony.com>
18+
*
19+
* @final since Symfony 7.4
2020
*/
2121
class Profile
2222
{
@@ -248,6 +248,9 @@ public function hasCollector(string $name): bool
248248
return isset($this->collectors[$name]);
249249
}
250250

251+
/**
252+
* @internal since Symfony 7.4, will be replaced by `__serialize()` in 8.0
253+
*/
251254
public function __sleep(): array
252255
{
253256
return ['token', 'parent', 'children', 'collectors', 'ip', 'method', 'url', 'time', 'statusCode', 'virtualType'];

0 commit comments

Comments
 (0)