feature #38052 Increase HttpBrowser::getHeaders() visibility to protected (iansltx)

fabpot · fabpot · commit c2522fa325c3 · 2020-09-04T07:30:17.000+02:00
This PR was merged into the 5.2-dev branch. Discussion ---------- Increase HttpBrowser::getHeaders() visibility to protected Resolves #38051 | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix #38051 | License | MIT | Doc PR | symfony/symfony-docs#...  Increases visibility to allow for oddball header overrides; see #38051 for more detail. If this looks good, let me know if this is worth adding docs/changelog entries and I'll do so. Commits ------- 3d75ab5 Increase HttpBrowser::getHeaders() visibility to protected
diff --git a/src/Symfony/Component/BrowserKit/HttpBrowser.php b/src/Symfony/Component/BrowserKit/HttpBrowser.php
@@ -94,7 +94,7 @@ private function getBodyAndExtraHeaders(Request $request, array $headers): array
         return [http_build_query($fields, '', '&', \PHP_QUERY_RFC1738), ['Content-Type' => 'application/x-www-form-urlencoded']];
     }
 
-    private function getHeaders(Request $request): array
+    protected function getHeaders(Request $request): array
     {
         $headers = [];
         foreach ($request->getServer() as $key => $value) {

Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,7 @@ private function getBodyAndExtraHeaders(Request $request, array $headers): array`
`94`	`94`	`return [http_build_query($fields, '', '&', \PHP_QUERY_RFC1738), ['Content-Type' => 'application/x-www-form-urlencoded']];`
`95`	`95`	`}`
`96`	`96`
`97`		`- private function getHeaders(Request $request): array`
	`97`	`+ protected function getHeaders(Request $request): array`
`98`	`98`	`{`
`99`	`99`	`$headers = [];`
`100`	`100`	`foreach ($request->getServer() as $key => $value) {`