bug #49849 [FrameworkBundle] Fix services usages output for text descriptor (rmikalkenas)

fabpot · fabpot · commit bf65d7b1c17e · 2023-03-31T11:55:36.000+02:00
This PR was merged into the 6.2 branch. Discussion ---------- [FrameworkBundle] Fix services usages output for text descriptor | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - If service is being used by lots of other services, the debug container command becomes unreadable, because `Usages` expands table. Replacing `, ` separator with new line fixes this issue Commits ------- 71baeab [FrameworkBundle] Fix services usages output for text descriptor
diff --git a/src/Symfony/Bundle/FrameworkBundle/Console/Descriptor/TextDescriptor.php b/src/Symfony/Bundle/FrameworkBundle/Console/Descriptor/TextDescriptor.php
@@ -361,7 +361,7 @@ protected function describeContainerDefinition(Definition $definition, array $op
         }
 
         $inEdges = null !== $builder && isset($options['id']) ? $this->getServiceEdges($builder, $options['id']) : [];
-        $tableRows[] = ['Usages', $inEdges ? implode(', ', $inEdges) : 'none'];
+        $tableRows[] = ['Usages', $inEdges ? implode(\PHP_EOL, $inEdges) : 'none'];
 
         $options['output']->table($tableHeaders, $tableRows);
     }

Original file line number	Diff line number	Diff line change
`@@ -361,7 +361,7 @@ protected function describeContainerDefinition(Definition $definition, array $op`
`361`	`361`	`}`
`362`	`362`
`363`	`363`	`$inEdges = null !== $builder && isset($options['id']) ? $this->getServiceEdges($builder, $options['id']) : [];`
`364`		`- $tableRows[] = ['Usages', $inEdges ? implode(', ', $inEdges) : 'none'];`
	`364`	`+ $tableRows[] = ['Usages', $inEdges ? implode(\PHP_EOL, $inEdges) : 'none'];`
`365`	`365`
`366`	`366`	`$options['output']->table($tableHeaders, $tableRows);`
`367`	`367`	`}`