bug #17561 [WebProfilerBundle] Fix design issue in profiler when having errors in forms (Pierstoval)

fabpot · fabpot · commit bd588a39281c · 2016-03-01T07:14:52.000+01:00
This PR was squashed before being merged into the 2.8 branch (closes #17561). Discussion ---------- [WebProfilerBundle] Fix design issue in profiler when having errors in forms | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a This error occurs mostly when having long form field names or types, **Before:** ![before](https://cloud.githubusercontent.com/assets/3369266/12610913/89bddfd8-c4ea-11e5-9372-2b7740d8c4b3.png) **After:** ![after](https://cloud.githubusercontent.com/assets/3369266/12610915/8ae22a4a-c4ea-11e5-94ce-9257a9409b4a.png) That said, I don't know what to do about z-index, whether the error count prevails on the type or *vice-versa* 😕 @javiereguiluz, an idea ? Commits ------- 76e1c0a [WebProfilerBundle] Fix design issue in profiler when having errors in forms
diff --git a/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/form.html.twig b/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/form.html.twig
@@ -427,17 +427,17 @@
     {% import _self as tree %}
     <li>
         <div class="tree-inner" data-tab-target-id="{{ data.id }}-details">
+            {% if data.errors is defined and data.errors|length > 0 %}
+                <div class="badge-error">{{ data.errors|length }}</div>
+            {% endif %}
+
             {% if data.children is not empty %}
                 <a class="toggle-button" data-toggle-target-id="{{ data.id }}-children" href="#"><span class="toggle-icon"></span></a>
             {% else %}
                 <div class="toggle-icon empty"></div>
             {% endif %}
 
             {{ name|default('(no name)') }} {% if data.type_class is defined and data.type is defined %}[<abbr title="{{ data.type_class }}">{{ data.type|split('\\')|last }}</abbr>]{% endif %}
-
-            {% if data.errors is defined and data.errors|length > 0 %}
-                <div class="badge-error">{{ data.errors|length }}</div>
-            {% endif %}
         </div>
 
         {% if data.children is not empty %}
