[ClassLoader] Fix storing not-found classes in APC cache

nicolas-grekas · nicolas-grekas · commit bc3b4f58107c · 2016-03-25T16:27:11.000+01:00
diff --git a/src/Symfony/Component/ClassLoader/ApcClassLoader.php b/src/Symfony/Component/ClassLoader/ApcClassLoader.php
@@ -118,11 +118,13 @@ public function loadClass($class)
      *
      * @param string $class A class name to resolve to file
      *
-     * @return string|null
+     * @return string|false
      */
     public function findFile($class)
     {
-        if (false === $file = apcu_fetch($this->prefix.$class)) {
+        $file = apcu_fetch($this->prefix.$class, $success);
+
+        if (!$success) {
             apcu_store($this->prefix.$class, $file = $this->decorated->findFile($class));
         }
 

Original file line number	Diff line number	Diff line change
`@@ -118,11 +118,13 @@ public function loadClass($class)`
`118`	`118`	`*`
`119`	`119`	`* @param string $class A class name to resolve to file`
`120`	`120`	`*`
`121`		`- * @return string\|null`
	`121`	`+ * @return string\|false`
`122`	`122`	`*/`
`123`	`123`	`public function findFile($class)`
`124`	`124`	`{`
`125`		`- if (false === $file = apcu_fetch($this->prefix.$class)) {`
	`125`	`+ $file = apcu_fetch($this->prefix.$class, $success);`
	`126`	`+`
	`127`	`+ if (!$success) {`
`126`	`128`	`apcu_store($this->prefix.$class, $file = $this->decorated->findFile($class));`
`127`	`129`	`}`
`128`	`130`