bug #38094 [PhpUnitBridge] Skip internal classes in CoverageListenerTrait (sanmai)

nicolas-grekas · nicolas-grekas · commit ba61d89ff457 · 2020-09-08T09:26:29.000+02:00
This PR was squashed before being merged into the 4.4 branch. Discussion ---------- [PhpUnitBridge] Skip internal classes in CoverageListenerTrait PHPUnit 9+ is picky about test covering, say, a `\RuntimeException`. Fails with the likes: "@Covers RuntimeException" is invalid Judging by the commit sebastianbergmann/phpunit@e06850c this change is required for PHPUnit 9.1 and up. [Here's it being tested.](https://github.com/sebastianbergmann/code-unit/blob/60c6fb972b3262e423be3000e7b8c67cbc477580/tests/unit/ClassMethodUnitTest.php#L49-L54) | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Follow-up to #38054 | License | MIT Commits ------- a0dedb9 [PhpUnitBridge] Skip internal classes in CoverageListenerTrait
diff --git a/src/Symfony/Bridge/PhpUnit/Legacy/CoverageListenerTrait.php b/src/Symfony/Bridge/PhpUnit/Legacy/CoverageListenerTrait.php
@@ -107,6 +107,13 @@ private function addCoversForDocBlockInsideRegistry($test, $covers)
         $symbolAnnotations = new \ReflectionProperty($docBlock, 'symbolAnnotations');
         $symbolAnnotations->setAccessible(true);
 
+        // Exclude internal classes; PHPUnit 9.1+ is picky about tests covering, say, a \RuntimeException
+        $covers = array_filter($covers, function ($class) {
+            $reflector = new ReflectionClass($class);
+
+            return $reflector->isUserDefined();
+        });
+
         $symbolAnnotations->setValue($docBlock, array_replace($docBlock->symbolAnnotations(), [
             'covers' => $covers,
         ]));
