feature #15290 [DependencyInjection] Forbid container cloning (jakzal)

fabpot · fabpot · commit b9f45d1a0a0c · 2015-07-16T14:20:08.000+02:00
This PR was merged into the 2.8 branch. Discussion ---------- [DependencyInjection] Forbid container cloning | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #15261 | License | MIT | Doc PR | - Commits ------- ba12904 [DependencyInjection] Forbid container cloning
diff --git a/src/Symfony/Component/DependencyInjection/Container.php b/src/Symfony/Component/DependencyInjection/Container.php
@@ -604,4 +604,8 @@ public static function underscore($id)
     {
         return strtolower(preg_replace(array('/([A-Z]+)([A-Z][a-z])/', '/([a-z\d])([A-Z])/'), array('\\1_\\2', '\\1_\\2'), strtr($id, '_', '.')));
     }
+
+    private function __clone()
+    {
+    }
 }
diff --git a/src/Symfony/Component/DependencyInjection/Tests/ContainerTest.php b/src/Symfony/Component/DependencyInjection/Tests/ContainerTest.php
@@ -662,6 +662,16 @@ public function testAlias()
         $this->assertTrue($c->has('alias'));
         $this->assertSame($c->get('alias'), $c->get('bar'));
     }
+
+    public function testThatCloningIsNotSupported()
+    {
+        $class = new \ReflectionClass('Symfony\Component\DependencyInjection\Container');
+        $clone = $class->getMethod('__clone');
+        if (PHP_VERSION_ID >= 540000) {
+            $this->assertFalse($class->isCloneable());
+        }
+        $this->assertTrue($clone->isPrivate());
+    }
 }
 
 class ProjectServiceContainer extends Container

Original file line number	Diff line number	Diff line change
`@@ -604,4 +604,8 @@ public static function underscore($id)`
`604`	`604`	`{`
`605`	`605`	`return strtolower(preg_replace(array('/([A-Z]+)([A-Z][a-z])/', '/([a-z\d])([A-Z])/'), array('\\1_\\2', '\\1_\\2'), strtr($id, '_', '.')));`
`606`	`606`	`}`
	`607`	`+`
	`608`	`+ private function __clone()`
	`609`	`+ {`
	`610`	`+ }`
`607`	`611`	`}`