feature #27315 [TwigBundle] add exception chain breadcrumbs navigation (kiler129)

fabpot · fabpot · commit b560883ffe49 · 2018-06-14T07:06:08.000+02:00
This PR was merged into the 4.2-dev branch. Discussion ---------- [TwigBundle] add exception chain breadcrumbs navigation | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #26824 | License | MIT | Doc PR | - Small DX improvement allowing to jump to exception in chain: ![preview](https://media.giphy.com/media/23chfZo9oFzdOrZzYl/giphy.gif) Commits ------- 5551e0c feature #26824 add exception chain breadcrumbs navigation
diff --git a/src/Symfony/Bundle/TwigBundle/Resources/views/Exception/exception.html.twig b/src/Symfony/Bundle/TwigBundle/Resources/views/Exception/exception.html.twig
@@ -3,10 +3,10 @@
         <div class="container">
             <h2 class="exception-hierarchy">
                 {% for previousException in exception.allPrevious|reverse %}
-                    {{ previousException.class|abbr_class }}
+                    <a href="#trace-box-{{ loop.revindex + 1 }}">{{ previousException.class|abbr_class }}</a>
                     <span class="icon">{{ include('@Twig/images/chevron-right.svg') }}</span>
                 {% endfor %}
-                {{ exception.class|abbr_class }}
+                <a href="#trace-box-1">{{ exception.class|abbr_class }}</a>
             </h2>
             <h2 class="exception-http">
                 HTTP {{ status_code }} <small>{{ status_text }}</small>
diff --git a/src/Symfony/Bundle/TwigBundle/Resources/views/Exception/traces.html.twig b/src/Symfony/Bundle/TwigBundle/Resources/views/Exception/traces.html.twig
@@ -1,4 +1,4 @@
-<div class="trace trace-as-html">
+<div class="trace trace-as-html" id="trace-box-{{ index }}">
     <div class="trace-details">
         <div class="trace-head">
             <span class="sf-toggle" data-toggle-selector="#trace-html-{{ index }}" data-toggle-initial="{{ expand ? 'display' }}">
diff --git a/src/Symfony/Bundle/TwigBundle/Resources/views/exception.css.twig b/src/Symfony/Bundle/TwigBundle/Resources/views/exception.css.twig
@@ -73,7 +73,7 @@ header .container { display: flex; justify-content: space-between; }
 .exception-summary { background: #B0413E; border-bottom: 2px solid rgba(0, 0, 0, 0.1); border-top: 1px solid rgba(0, 0, 0, .3); flex: 0 0 auto; margin-bottom: 15px; }
 .exception-metadata { background: rgba(0, 0, 0, 0.1); padding: 7px 0; }
 .exception-metadata .container { display: flex; flex-direction: row; justify-content: space-between; }
-.exception-metadata h2 { color: rgba(255, 255, 255, 0.8); font-size: 13px; font-weight: 400; margin: 0; }
+.exception-metadata h2, .exception-metadata h2 > a { color: rgba(255, 255, 255, 0.8); font-size: 13px; font-weight: 400; margin: 0; }
 .exception-http small { font-size: 13px; opacity: .7; }
 .exception-hierarchy { flex: 1; }
 .exception-hierarchy .icon { margin: 0 3px; opacity: .7; }

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-<div class="trace trace-as-html">`
	`1`	`+<div class="trace trace-as-html" id="trace-box-{{ index }}">`
`2`	`2`	`<div class="trace-details">`
`3`	`3`	`<div class="trace-head">`
`4`	`4`	`<span class="sf-toggle" data-toggle-selector="#trace-html-{{ index }}" data-toggle-initial="{{ expand ? 'display' }}">`