bug #54863 [Process] Return false when open_basedir prevents access to /dev/tty (mjauvin)

xabbuh · xabbuh · commit b49df796764f · 2024-05-15T09:06:14.000+02:00
This PR was merged into the 6.4 branch. Discussion ---------- [Process] Return `false` when `open_basedir` prevents access to `/dev/tty` | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no If open_basedir restrictions are in effect, checking if the file /dev/tty is writable will prevent setting tty mode on the process, and avoid failing to create a Process. Fixes #54874 Commits ------- 825e38b Return false in isTtySupported() when open_basedir restrictions prevent access to /dev/tty.
diff --git a/src/Symfony/Component/Process/Process.php b/src/Symfony/Component/Process/Process.php
@@ -1211,7 +1211,7 @@ public static function isTtySupported(): bool
     {
         static $isTtySupported;
 
-        return $isTtySupported ??= ('/' === \DIRECTORY_SEPARATOR && stream_isatty(\STDOUT));
+        return $isTtySupported ??= ('/' === \DIRECTORY_SEPARATOR && stream_isatty(\STDOUT) && @is_writable('/dev/tty'));
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -1211,7 +1211,7 @@ public static function isTtySupported(): bool`
`1211`	`1211`	`{`
`1212`	`1212`	`static $isTtySupported;`
`1213`	`1213`
`1214`		`- return $isTtySupported ??= ('/' === \DIRECTORY_SEPARATOR && stream_isatty(\STDOUT));`
	`1214`	`+ return $isTtySupported ??= ('/' === \DIRECTORY_SEPARATOR && stream_isatty(\STDOUT) && @is_writable('/dev/tty'));`
`1215`	`1215`	`}`
`1216`	`1216`
`1217`	`1217`	`/**`