bug #62347 [OptionsResolver] Ensure remove() also unsets deprecation status (yoeunes)

nicolas-grekas · nicolas-grekas · commit b0d77adec861 · 2025-11-12T14:04:06.000+01:00
This PR was merged into the 6.4 branch. Discussion ---------- [OptionsResolver] Ensure remove() also unsets deprecation status | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | - | License | MIT This ensures `remove()` fully clears an option, including any deprecation, allowing clean overrides in child configs (as suggested by `@yceruto` in #62345). Commits ------- 5ffa260 [OptionsResolver] Ensure remove() also unsets deprecation status
diff --git a/src/Symfony/Component/OptionsResolver/OptionsResolver.php b/src/Symfony/Component/OptionsResolver/OptionsResolver.php
@@ -803,7 +803,7 @@ public function remove(string|array $optionNames): static
 
         foreach ((array) $optionNames as $option) {
             unset($this->defined[$option], $this->defaults[$option], $this->required[$option], $this->resolved[$option]);
-            unset($this->lazy[$option], $this->normalizers[$option], $this->allowedTypes[$option], $this->allowedValues[$option], $this->info[$option]);
+            unset($this->lazy[$option], $this->normalizers[$option], $this->allowedTypes[$option], $this->allowedValues[$option], $this->info[$option], $this->deprecated[$option]);
         }
 
         return $this;
diff --git a/src/Symfony/Component/OptionsResolver/Tests/OptionsResolverTest.php b/src/Symfony/Component/OptionsResolver/Tests/OptionsResolverTest.php
@@ -2566,4 +2566,33 @@ public function testPrototypeDefinition()
 
         $this->assertSame($expectedOptions, $actualOptions);
     }
+
+    public function testRemoveAlsoRemovesDeprecation()
+    {
+        $this->resolver->setDefined('foo');
+        $this->resolver->setDeprecated('foo', 'vendor/package', '1.0');
+        $this->assertTrue($this->resolver->isDeprecated('foo'));
+
+        $this->resolver->remove('foo');
+        $this->assertFalse($this->resolver->isDeprecated('foo'));
+
+        $this->resolver->setDefault('foo', 'bar');
+        $this->assertFalse($this->resolver->isDeprecated('foo'));
+
+        $count = 0;
+        set_error_handler(static function (int $type) use (&$count) {
+            if (\E_USER_DEPRECATED === $type) {
+                ++$count;
+            }
+
+            return false;
+        });
+
+        try {
+            $this->resolver->resolve(['foo' => 'value']);
+            $this->assertSame(0, $count);
+        } finally {
+            restore_error_handler();
+        }
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -803,7 +803,7 @@ public function remove(string\|array $optionNames): static`
`803`	`803`
`804`	`804`	`foreach ((array) $optionNames as $option) {`
`805`	`805`	`unset($this->defined[$option], $this->defaults[$option], $this->required[$option], $this->resolved[$option]);`
`806`		`- unset($this->lazy[$option], $this->normalizers[$option], $this->allowedTypes[$option], $this->allowedValues[$option], $this->info[$option]);`
	`806`	`+ unset($this->lazy[$option], $this->normalizers[$option], $this->allowedTypes[$option], $this->allowedValues[$option], $this->info[$option], $this->deprecated[$option]);`
`807`	`807`	`}`
`808`	`808`
`809`	`809`	`return $this;`