Apply suggestions from code review

GromNaN · nicolas-grekas · web-flow · commit ade53e75c538 · 2025-02-11T12:03:34.000+01:00
Co-authored-by: Nicolas Grekas &lt;nicolas.grekas@gmail.com&gt;
diff --git a/src/Symfony/Component/DependencyInjection/CHANGELOG.md b/src/Symfony/Component/DependencyInjection/CHANGELOG.md
@@ -8,7 +8,7 @@ CHANGELOG
  * Support `@>` as a shorthand for `!service_closure` in yaml files
  * Don't skip classes with private constructor when autodiscovering
  * Add `Definition::addExcludeTag()` and `ContainerBuilder::findExcludedServiceIds()`
-   for auto-configuration of classes excluded from the service container.
+   for auto-configuration of classes excluded from the service container
 
 7.2
 ---
diff --git a/src/Symfony/Component/DependencyInjection/ContainerBuilder.php b/src/Symfony/Component/DependencyInjection/ContainerBuilder.php
@@ -1374,7 +1374,7 @@ public function findExcludedServiceIds(string $tagName): array
         foreach ($this->getDefinitions() as $id => $definition) {
             if ($definition->hasTag($tagName)) {
                 if (!$definition->hasTag('container.excluded')) {
-                    throw new InvalidArgumentException(\sprintf('The service "%s" tagged "%s" must have the "container.excluded" tag.', $id, $tagName));
+                    throw new InvalidArgumentException(\sprintf('The service "%s" tagged "%s" is missing the "container.excluded" tag.', $id, $tagName));
                 }
                 $tags[$id] = $definition->getTag($tagName);
             }
diff --git a/src/Symfony/Component/DependencyInjection/Definition.php b/src/Symfony/Component/DependencyInjection/Definition.php
@@ -458,7 +458,7 @@ public function addTag(string $name, array $attributes = []): static
     /**
      * Adds a tag to the definition and marks it as excluded.
      *
-     * This definitions must be processed using {@see ContainerBuilder::findExcludedServiceIds()}
+     * This definitions should be processed using {@see ContainerBuilder::findExcludedServiceIds()}
      *
      * @return $this
      */

Original file line number	Diff line number	Diff line change
`@@ -1374,7 +1374,7 @@ public function findExcludedServiceIds(string $tagName): array`
`1374`	`1374`	`foreach ($this->getDefinitions() as $id => $definition) {`
`1375`	`1375`	`if ($definition->hasTag($tagName)) {`
`1376`	`1376`	`if (!$definition->hasTag('container.excluded')) {`
`1377`		`- throw new InvalidArgumentException(\sprintf('The service "%s" tagged "%s" must have the "container.excluded" tag.', $id, $tagName));`
	`1377`	`+ throw new InvalidArgumentException(\sprintf('The service "%s" tagged "%s" is missing the "container.excluded" tag.', $id, $tagName));`
`1378`	`1378`	`}`
`1379`	`1379`	`$tags[$id] = $definition->getTag($tagName);`
`1380`	`1380`	`}`
Original file line number	Diff line number	Diff line change
`@@ -458,7 +458,7 @@ public function addTag(string $name, array $attributes = []): static`
`458`	`458`	`/**`
`459`	`459`	`* Adds a tag to the definition and marks it as excluded.`
`460`	`460`	`*`
`461`		`- * This definitions must be processed using {@see ContainerBuilder::findExcludedServiceIds()}`
	`461`	`+ * This definitions should be processed using {@see ContainerBuilder::findExcludedServiceIds()}`
`462`	`462`	`*`
`463`	`463`	`* @return $this`
`464`	`464`	`*/`