accept format arg - default to json

jrushlow · jrushlow · commit ad5255fa375f · 2021-02-26T18:51:17.000-05:00
diff --git a/src/Symfony/Bridge/Twig/Extension/SerializeExtension.php b/src/Symfony/Bridge/Twig/Extension/SerializeExtension.php
@@ -34,8 +34,8 @@ public function getFilters(): array
         ];
     }
 
-    public function serialize(object $object): string
+    public function serialize(object $object, string $format = 'json'): string
     {
-        return $this->serializer->serialize($object, 'json');
+        return $this->serializer->serialize($object, $format);
     }
 }
diff --git a/src/Symfony/Bridge/Twig/Tests/Extension/SerializerExtensionTest.php b/src/Symfony/Bridge/Twig/Tests/Extension/SerializerExtensionTest.php
@@ -14,6 +14,7 @@
 use PHPUnit\Framework\TestCase;
 use Symfony\Bridge\Twig\Extension\SerializeExtension;
 use Symfony\Component\Serializer\Encoder\JsonEncoder;
+use Symfony\Component\Serializer\Encoder\YamlEncoder;
 use Symfony\Component\Serializer\Normalizer\ObjectNormalizer;
 use Symfony\Component\Serializer\Serializer;
 use Twig\Environment;
@@ -24,7 +25,7 @@
  */
 class SerializerExtensionTest extends TestCase
 {
-    public function testSerializer()
+    public function testSerializeDefaultsToJson()
     {
         $extension = new SerializeExtension(new Serializer([new ObjectNormalizer()], [new JsonEncoder()]));
 
@@ -40,4 +41,21 @@ public function testSerializer()
 
         self::assertSame('{&quot;title&quot;:&quot;testing&quot;}', $result);
     }
+
+    public function testSerializeAcceptsFormat()
+    {
+        $extension = new SerializeExtension(new Serializer([new ObjectNormalizer()], [new JsonEncoder(), new YamlEncoder()]));
+
+        $object = new \stdClass();
+        $object->title = 'testing';
+
+        $template = '{{ object|serialize(\'yaml\') }}';
+
+        $twig = new Environment(new ArrayLoader(['template' => $template]));
+        $twig->addExtension($extension);
+
+        $result = $twig->render('template', ['object' => $object]);
+
+        self::assertSame('{ title: testing }', $result);
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -34,8 +34,8 @@ public function getFilters(): array`
`34`	`34`	`];`
`35`	`35`	`}`
`36`	`36`
`37`		`- public function serialize(object $object): string`
	`37`	`+ public function serialize(object $object, string $format = 'json'): string`
`38`	`38`	`{`
`39`		`- return $this->serializer->serialize($object, 'json');`
	`39`	`+ return $this->serializer->serialize($object, $format);`
`40`	`40`	`}`
`41`	`41`	`}`