[DependencyInjection] Reset resolved state when setting a parameter

yoeunes · yoeunes · commit ad3b789e7f18 · 2025-11-28T07:24:02.000+01:00
diff --git a/src/Symfony/Component/DependencyInjection/ParameterBag/ParameterBag.php b/src/Symfony/Component/DependencyInjection/ParameterBag/ParameterBag.php
@@ -112,6 +112,7 @@ public function set(string $name, array|bool|string|int|float|\UnitEnum|null $va
         }
 
         $this->parameters[$name] = $value;
+        $this->resolved = false;
     }
 
     /**
diff --git a/src/Symfony/Component/DependencyInjection/Tests/ParameterBag/ParameterBagTest.php b/src/Symfony/Component/DependencyInjection/Tests/ParameterBag/ParameterBagTest.php
@@ -356,4 +356,21 @@ public static function stringsWithSpacesProvider()
             ['50% is less than 100%', '50% is less than 100%', 'Text between % signs is allowed, if there are spaces.'],
         ];
     }
+
+    public function testAddParametersAfterResolveBreaksConsistency()
+    {
+        $bag = new ParameterBag(['kernel.project_dir' => '/var/www/my_project']);
+        $bag->resolve();
+
+        $this->assertTrue($bag->isResolved());
+
+        $bag->set('app.uploads_dir', '%kernel.project_dir%/public/uploads');
+        $bag->resolve();
+
+        $this->assertSame(
+            '/var/www/my_project/public/uploads',
+            $bag->get('app.uploads_dir'),
+            'ParameterBag failed to resolve new parameters added after initial resolution.'
+        );
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -112,6 +112,7 @@ public function set(string $name, array\|bool\|string\|int\|float\|\UnitEnum\|null $va`
`112`	`112`	`}`
`113`	`113`
`114`	`114`	`$this->parameters[$name] = $value;`
	`115`	`+ $this->resolved = false;`
`115`	`116`	`}`
`116`	`117`
`117`	`118`	`/**`