refs #26898

Pascal Montoya · Pascal Montoya · commit acfb325a351a · 2018-06-18T12:27:44.000+02:00
Remove unnecessary loop
Trim messages on build rather than on display
diff --git a/src/Symfony/Bridge/Twig/Command/DebugCommand.php b/src/Symfony/Bridge/Twig/Command/DebugCommand.php
@@ -89,16 +89,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
             $data['tests'] = array_keys($data['tests']);
             $data['loader_paths'] = $this->getLoaderPaths();
             if ($wrongBundles = $this->findWrongBundleOverrides()) {
-                $messages = $this->buildWarningMessages($wrongBundles);
-                $data['warnings'] = array_reduce(
-                    $messages,
-                    function ($carry, $message) {
-                        $carry[] = $message;
-
-                        return $carry;
-                    },
-                    array()
-                );
+                $data['warnings'] = $this->buildWarningMessages($wrongBundles);
             }
 
             $io->writeln(json_encode($data));
@@ -143,12 +134,9 @@ function ($carry, $message) {
         $io->section('Loader Paths');
         $io->table(array('Namespace', 'Paths'), $rows);
         $messages = $this->buildWarningMessages($this->findWrongBundleOverrides());
-        array_walk(
-            $messages,
-            function ($message) use ($io) {
-                $io->warning(trim($message));
-            }
-         );
+        foreach ($messages as $message) {
+            $io->warning($message);
+        }
 
         return 0;
     }
@@ -344,7 +332,7 @@ private function buildWarningMessages(array $wrongBundles): array
                     }
                 }
             }
-            $messages[] = $message;
+            $messages[] = trim($message);
         }
 
         return $messages;
