throw exception when using alias on non invokable class

damienfern · damienfern · commit abf4cf2281f0 · 2024-11-13T10:42:29.000+01:00
diff --git a/src/Symfony/Component/Routing/Loader/AttributeClassLoader.php b/src/Symfony/Component/Routing/Loader/AttributeClassLoader.php
@@ -107,6 +107,15 @@ public function load(mixed $class, ?string $type = null): RouteCollection
             return $collection;
         }
         $fqcnAlias = false;
+
+        if (!$class->hasMethod('__invoke')) {
+            foreach ($this->getAttributes($class) as $attr) {
+                if (0 !== \count($attr->getAliases())) {
+                    throw new \InvalidArgumentException(\sprintf('Class "%s" cannot have aliases as it does not have an "__invoke" method.', $class->name));
+                }
+            }
+        }
+
         foreach ($class->getMethods() as $method) {
             $this->defaultRouteIndex = 0;
             $routeNamesBefore = array_keys($collection->all());
diff --git a/src/Symfony/Component/Routing/Tests/Fixtures/AttributeFixtures/AliasClassController.php b/src/Symfony/Component/Routing/Tests/Fixtures/AttributeFixtures/AliasClassController.php
@@ -2,7 +2,20 @@
 
 namespace Symfony\Component\Routing\Tests\Fixtures\AttributeFixtures;
 
+use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
+use Symfony\Component\Routing\Attribute\Route;
+
+#[Route('/hello', alias: ['alias', 'completely_different_name'])]
 class AliasClassController
 {
 
+    #[Route('/world')]
+    public function actionWorld()
+    {
+    }
+
+    #[Route('/symfony')]
+    public function actionSymfony()
+    {
+    }
 }
diff --git a/src/Symfony/Component/Routing/Tests/Fixtures/AttributeFixtures/AliasInvokableController.php b/src/Symfony/Component/Routing/Tests/Fixtures/AttributeFixtures/AliasInvokableController.php
@@ -2,7 +2,14 @@
 
 namespace Symfony\Component\Routing\Tests\Fixtures\AttributeFixtures;
 
+use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
+use Symfony\Component\Routing\Attribute\Route;
+
+#[Route('/path', name:'invokable_path', alias: ['alias', 'completely_different_name'])]
 class AliasInvokableController
 {
 
+    public function __invoke()
+    {
+    }
 }
diff --git a/src/Symfony/Component/Routing/Tests/Loader/AttributeClassLoaderTest.php b/src/Symfony/Component/Routing/Tests/Loader/AttributeClassLoaderTest.php
@@ -16,6 +16,8 @@
 use Symfony\Component\Routing\Exception\LogicException;
 use Symfony\Component\Routing\Tests\Fixtures\AttributeFixtures\AbstractClassController;
 use Symfony\Component\Routing\Tests\Fixtures\AttributeFixtures\ActionPathController;
+use Symfony\Component\Routing\Tests\Fixtures\AttributeFixtures\AliasClassController;
+use Symfony\Component\Routing\Tests\Fixtures\AttributeFixtures\AliasInvokableController;
 use Symfony\Component\Routing\Tests\Fixtures\AttributeFixtures\AliasRouteController;
 use Symfony\Component\Routing\Tests\Fixtures\AttributeFixtures\BazClass;
 use Symfony\Component\Routing\Tests\Fixtures\AttributeFixtures\DefaultValueController;
@@ -366,7 +368,7 @@ public function testDefaultRouteName()
         $this->assertSame('symfony_component_routing_tests_fixtures_attributefixtures_encodingclass_routeàction', $defaultName);
     }
 
-    public function testAliases()
+    public function testAliasesOnMethod()
     {
         $routes = $this->loader->load(AliasRouteController::class);
         $route = $routes->get('action_with_alias');
@@ -375,4 +377,22 @@ public function testAliases()
         $this->assertEquals(new Alias('action_with_alias'), $routes->getAlias('alias'));
         $this->assertEquals(new Alias('action_with_alias'), $routes->getAlias('completely_different_name'));
     }
+
+    public function testThrowsWithAliasesOnClass()
+    {
+        $this->expectException(\InvalidArgumentException::class);
+        $this->expectExceptionMessage('Class "Symfony\Component\Routing\Tests\Fixtures\AttributeFixtures\AliasClassController" cannot have aliases as it does not have an "__invoke" method.');
+
+        $this->loader->load(AliasClassController::class);
+    }
+
+    public function testAliasesOnInvokableClass()
+    {
+        $routes = $this->loader->load(AliasInvokableController::class);
+        $route = $routes->get('invokable_path');
+        $this->assertCount(1, $routes);
+        $this->assertEquals('/path', $route->getPath());
+        $this->assertEquals(new Alias('invokable_path'), $routes->getAlias('alias'));
+        $this->assertEquals(new Alias('invokable_path'), $routes->getAlias('completely_different_name'));
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,14 @@`
`2`	`2`
`3`	`3`	`namespace Symfony\Component\Routing\Tests\Fixtures\AttributeFixtures;`
`4`	`4`
	`5`	`+use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;`
	`6`	`+use Symfony\Component\Routing\Attribute\Route;`
	`7`	`+`
	`8`	`+#[Route('/path', name:'invokable_path', alias: ['alias', 'completely_different_name'])]`
`5`	`9`	`class AliasInvokableController`
`6`	`10`	`{`
`7`	`11`
	`12`	`+ public function __invoke()`
	`13`	`+ {`
	`14`	`+ }`
`8`	`15`	`}`