bug #62772 [PropertyInfo] Fix calling same-named method with required args instead of reading public property (makraz)

nicolas-grekas · nicolas-grekas · commit a923e6c1b10a · 2025-12-16T20:55:36.000+01:00
This PR was submitted for the 7.3 branch but it was merged into the 6.4 branch instead. Discussion ---------- [PropertyInfo] Fix calling same-named method with required args instead of reading public property | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #62733 | License | MIT - Fixes PropertyAccess choosing a same‑named method over a public property when the method requires parameters. - Ensures jQuery‑style accessors (methods named exactly like the property) are only considered if they have zero required parameters. - Prevents `ArgumentCountError` during serialization and aligns behavior with standard getter rules (`getX()/isX()/hasX()/canX()`), which already require zero required parameters. Commits ------- 02e3153 [PropertyInfo] Fix calling same-named method with required args instead of reading public property
diff --git a/src/Symfony/Component/PropertyAccess/Tests/PropertyAccessorTest.php b/src/Symfony/Component/PropertyAccess/Tests/PropertyAccessorTest.php
@@ -52,6 +52,21 @@ protected function setUp(): void
         $this->propertyAccessor = new PropertyAccessor();
     }
 
+    public function testPrefersPropertyOverMethodWithSameNameAndRequiredArgs()
+    {
+        $obj = new class {
+            public bool $loaded = true;
+
+            // Same name as property, but requires an argument: must NOT be called for reading
+            public function loaded(string $arg): bool
+            {
+                throw new \RuntimeException('Method should not be invoked during property read');
+            }
+        };
+
+        $this->assertTrue($this->propertyAccessor->getValue($obj, 'loaded'));
+    }
+
     public static function getPathsWithMissingProperty()
     {
         return [
diff --git a/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php b/src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php
@@ -270,8 +270,10 @@ public function getReadInfo(string $class, string $property, array $context = []
 
         if ($allowGetterSetter && $reflClass->hasMethod($getsetter) && ($reflClass->getMethod($getsetter)->getModifiers() & $this->methodReflectionFlags)) {
             $method = $reflClass->getMethod($getsetter);
-
-            return new PropertyReadInfo(PropertyReadInfo::TYPE_METHOD, $getsetter, $this->getReadVisibilityForMethod($method), $method->isStatic(), false);
+            // Only consider jQuery-style accessors when they don't require parameters
+            if (!$method->getNumberOfRequiredParameters()) {
+                return new PropertyReadInfo(PropertyReadInfo::TYPE_METHOD, $getsetter, $this->getReadVisibilityForMethod($method), $method->isStatic(), false);
+            }
         }
 
         if ($allowMagicGet && $reflClass->hasMethod('__get') && (($r = $reflClass->getMethod('__get'))->getModifiers() & $this->methodReflectionFlags)) {
