When calling UploadedFile::getErrorMessage() to a file which has no error and is uploaded successfully, it should not return an error

ArmCyber · ArmCyber · commit a80cb72f68a7 · 2024-03-15T21:18:41.000+04:00
diff --git a/src/Symfony/Component/HttpFoundation/File/UploadedFile.php b/src/Symfony/Component/HttpFoundation/File/UploadedFile.php
@@ -265,8 +265,14 @@ private static function parseFilesize(string $size): int|float
     /**
      * Returns an informative upload error message.
      */
-    public function getErrorMessage(): string
+    public function getErrorMessage(): ?string
     {
+        $errorCode = $this->error;
+
+        if ($errorCode === \UPLOAD_ERR_OK) {
+            return null;
+        }
+
         static $errors = [
             \UPLOAD_ERR_INI_SIZE => 'The file "%s" exceeds your upload_max_filesize ini directive (limit is %d KiB).',
             \UPLOAD_ERR_FORM_SIZE => 'The file "%s" exceeds the upload limit defined in your form.',
@@ -277,7 +283,6 @@ public function getErrorMessage(): string
             \UPLOAD_ERR_EXTENSION => 'File upload was stopped by a PHP extension.',
         ];
 
-        $errorCode = $this->error;
         $maxFilesize = \UPLOAD_ERR_INI_SIZE === $errorCode ? self::getMaxFilesize() / 1024 : 0;
         $message = $errors[$errorCode] ?? 'The file "%s" was not uploaded due to an unknown error.';
 
diff --git a/src/Symfony/Component/HttpFoundation/Tests/File/UploadedFileTest.php b/src/Symfony/Component/HttpFoundation/Tests/File/UploadedFileTest.php
@@ -119,6 +119,18 @@ public function testErrorIsOkByDefault()
         $this->assertEquals(\UPLOAD_ERR_OK, $file->getError());
     }
 
+    public function testErrorMessageIsNullIfErrorIsOk()
+    {
+        $file = new UploadedFile(
+            __DIR__.'/Fixtures/test.gif',
+            'original.gif',
+            'image/gif',
+            null
+        );
+
+        $this->assertEquals(null, $file->getErrorMessage());
+    }
+
     public function testGetClientOriginalName()
     {
         $file = new UploadedFile(
