fix group without last-delivered-id

Jean-Beru · Jean-Beru · commit a403e97fb538 · 2022-05-23T21:29:54.000+02:00
diff --git a/src/Symfony/Component/Messenger/Bridge/Redis/Transport/Connection.php b/src/Symfony/Component/Messenger/Bridge/Redis/Transport/Connection.php
@@ -523,11 +523,7 @@ public function cleanup(): void
 
     public function getMessageCount(): int
     {
-        $groups = $this->connection->xinfo('GROUPS', $this->stream);
-
-        if (false === $groups) {
-            throw new LogicException(sprintf('No group found for stream "%s".', $this->stream));
-        }
+        $groups = $this->connection->xinfo('GROUPS', $this->stream) ?: [];
 
         $lastDeliveredId = null;
         foreach ($groups as $group) {
@@ -540,7 +536,7 @@ public function getMessageCount(): int
                 return $group['lag'];
             }
 
-            $lastDeliveredId = $group['last-delivered-id'];
+            $lastDeliveredId = $group['last-delivered-id'] ?? '0-0';
             break;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -523,11 +523,7 @@ public function cleanup(): void`
`523`	`523`
`524`	`524`	`public function getMessageCount(): int`
`525`	`525`	`{`
`526`		`- $groups = $this->connection->xinfo('GROUPS', $this->stream);`
`527`		`-`
`528`		`- if (false === $groups) {`
`529`		`- throw new LogicException(sprintf('No group found for stream "%s".', $this->stream));`
`530`		`- }`
	`526`	`+ $groups = $this->connection->xinfo('GROUPS', $this->stream) ?: [];`
`531`	`527`
`532`	`528`	`$lastDeliveredId = null;`
`533`	`529`	`foreach ($groups as $group) {`
`@@ -540,7 +536,7 @@ public function getMessageCount(): int`
`540`	`536`	`return $group['lag'];`
`541`	`537`	`}`
`542`	`538`
`543`		`- $lastDeliveredId = $group['last-delivered-id'];`
	`539`	`+ $lastDeliveredId = $group['last-delivered-id'] ?? '0-0';`
`544`	`540`	`break;`
`545`	`541`	`}`
`546`	`542`