Skip to content

Commit 9fad15b

Browse files
mamazumamazu
committed
Only show relevant columns in debug:router
1 parent c83c34e commit 9fad15b

25 files changed

+220
-31
lines changed

‎src/Symfony/Bundle/FrameworkBundle/Console/Descriptor/TextDescriptor.php‎

Lines changed: 68 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -38,47 +38,82 @@
3838
*/
3939
class TextDescriptor extends Descriptor
4040
{
41+
private const VERB_COLORS = [
42+
'ANY' => 'default',
43+
'GET' => 'blue',
44+
'HEAD' => 'magenta',
45+
'OPTIONS' => 'blue',
46+
'POST' => 'green',
47+
'PUT' => 'yellow',
48+
'PATCH' => 'yellow',
49+
'DELETE' => 'red',
50+
];
51+
4152
public function __construct(
4253
private ?FileLinkFormatter $fileLinkFormatter = null,
4354
) {
4455
}
4556

4657
protected function describeRouteCollection(RouteCollection $routes, array $options = []): void
4758
{
48-
$showControllers = isset($options['show_controllers']) && $options['show_controllers'];
49-
50-
$tableHeaders = ['Name', 'Method', 'Scheme', 'Host', 'Path'];
51-
if ($showControllers) {
52-
$tableHeaders[] = 'Controller';
53-
}
54-
55-
if ($showAliases = $options['show_aliases'] ?? false) {
56-
$tableHeaders[] = 'Aliases';
57-
}
59+
$showAliases = $options['show_aliases'] ?? false;
60+
$showControllers = $options['show_controllers'] ?? false;
5861

5962
$tableRows = [];
63+
$shouldShowScheme = false;
64+
$shouldShowHost = false;
6065
foreach ($routes->all() as $name => $route) {
6166
$controller = $route->getDefault('_controller');
6267

68+
$scheme = $route->getSchemes() ? implode('|', $route->getSchemes()) : 'ANY';
69+
$shouldShowScheme = $shouldShowScheme || 'ANY' !== $scheme;
70+
71+
$host = '' !== $route->getHost() ? $route->getHost() : 'ANY';
72+
$shouldShowHost = $shouldShowHost || 'ANY' !== $host;
73+
6374
$row = [
64-
$name,
65-
$route->getMethods() ? implode('|', $route->getMethods()) : 'ANY',
66-
$route->getSchemes() ? implode('|', $route->getSchemes()) : 'ANY',
67-
'' !== $route->getHost() ? $route->getHost() : 'ANY',
68-
$this->formatControllerLink($controller, $route->getPath(), $options['container'] ?? null),
75+
'Name' => $name,
76+
'Methods' => $this->formatMethods($route->getMethods()),
77+
'Scheme' => $scheme,
78+
'Host' => $host,
79+
'Path' => $route->getPath(),
6980
];
7081

7182
if ($showControllers) {
72-
$row[] = $controller ? $this->formatControllerLink($controller, $this->formatCallable($controller), $options['container'] ?? null) : '';
83+
$row['Controller'] = $controller ? $this->formatControllerLink($controller, $this->formatCallable($controller), $options['container'] ?? null) : '';
7384
}
7485

7586
if ($showAliases) {
76-
$row[] = implode('|', ($reverseAliases ??= $this->getReverseAliases($routes))[$name] ?? []);
87+
$row['Aliases'] = implode('|', ($this->getReverseAliases($routes))[$name] ?? []);
7788
}
7889

7990
$tableRows[] = $row;
8091
}
8192

93+
$tableHeaders = ['Name', 'Method'];
94+
95+
if ($shouldShowScheme) {
96+
$tableHeaders[] = 'Scheme';
97+
} else {
98+
array_walk($tableRows, function (&$row) { unset($row['Scheme']); });
99+
}
100+
101+
if ($shouldShowHost) {
102+
$tableHeaders[] = 'Host';
103+
} else {
104+
array_walk($tableRows, function (&$row) { unset($row['Host']); });
105+
}
106+
107+
$tableHeaders[] = 'Path';
108+
109+
if ($showControllers) {
110+
$tableHeaders[] = 'Controller';
111+
}
112+
113+
if ($showAliases) {
114+
$tableHeaders[] = 'Aliases';
115+
}
116+
82117
if (isset($options['output'])) {
83118
$options['output']->table($tableHeaders, $tableRows);
84119
} else {
@@ -103,7 +138,7 @@ protected function describeRoute(Route $route, array $options = []): void
103138
['Host', '' !== $route->getHost() ? $route->getHost() : 'ANY'],
104139
['Host Regex', '' !== $route->getHost() ? $route->compile()->getHostRegex() : ''],
105140
['Scheme', $route->getSchemes() ? implode('|', $route->getSchemes()) : 'ANY'],
106-
['Method', $route->getMethods() ? implode('|', $route->getMethods()) : 'ANY'],
141+
['Method', $this->formatMethods($route->getMethods())],
107142
['Requirements', $route->getRequirements() ? $this->formatRouterConfig($route->getRequirements()) : 'NO CUSTOM'],
108143
['Class', $route::class],
109144
['Defaults', $this->formatRouterConfig($defaults)],
@@ -576,6 +611,21 @@ private function formatRouterConfig(array $config): string
576611
return trim($configAsString);
577612
}
578613

614+
/**
615+
* @param array<string> $methods
616+
*/
617+
private function formatMethods(array $methods): string
618+
{
619+
if (count($methods) === 0) {
620+
$methods = ['ANY'];
621+
}
622+
623+
return implode('|', array_map(
624+
fn (string $method): string => sprintf('<fg=%s>%s</>', self::VERB_COLORS[$method] ?? 'default', $method),
625+
$methods
626+
));
627+
}
628+
579629
/**
580630
* @param (callable():ContainerBuilder)|null $getContainer
581631
*/

‎src/Symfony/Bundle/FrameworkBundle/Tests/Console/Descriptor/AbstractDescriptorTestCase.php‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -323,7 +323,6 @@ private static function getContainerBuilderDescriptionTestData(array $objects):
323323
'public' => ['show_hidden' => false],
324324
'tag1' => ['show_hidden' => true, 'tag' => 'tag1'],
325325
'tags' => ['group_by' => 'tags', 'show_hidden' => true],
326-
'arguments' => ['show_hidden' => false],
327326
];
328327

329328
$data = [];

‎src/Symfony/Bundle/FrameworkBundle/Tests/Console/Descriptor/ObjectsProvider.php‎

Lines changed: 26 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,32 @@ public static function getRouteCollections()
3434
$collection1->add($name, $route);
3535
}
3636

37-
return ['route_collection_1' => $collection1];
37+
$routesWithGenericHost = new RouteCollection();
38+
$routesWithGenericHost->add('some_route', new RouteStub(
39+
'/some-route',
40+
['_controller' => 'Controller'],
41+
[],
42+
[],
43+
null,
44+
['https'],
45+
));
46+
47+
$routesWithGenericScheme = new RouteCollection();
48+
$routesWithGenericScheme->add('some_route_with_host', new RouteStub(
49+
'/some-route',
50+
['_controller' => 'strpos'],
51+
[],
52+
[],
53+
'symfony.com',
54+
[],
55+
));
56+
57+
return [
58+
'empty_route_collection' => new RouteCollection(),
59+
'route_collection_1' => $collection1,
60+
'route_with_generic_host' => $routesWithGenericHost,
61+
'route_with_generic_scheme' => $routesWithGenericScheme,
62+
];
3863
}
3964

4065
public static function getRouteCollectionsByHttpMethod(): array

‎src/Symfony/Bundle/FrameworkBundle/Tests/Fixtures/Descriptor/empty_route_collection.json‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
[]
2+

‎src/Symfony/Bundle/FrameworkBundle/Tests/Fixtures/Descriptor/empty_route_collection.md‎

Whitespace-only changes.

‎src/Symfony/Bundle/FrameworkBundle/Tests/Fixtures/Descriptor/empty_route_collection.txt‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
------ -------- ------
2+
 Name   Method   Path 
3+
------ -------- ------
4+

‎src/Symfony/Bundle/FrameworkBundle/Tests/Fixtures/Descriptor/empty_route_collection.xml‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<routes/>
3+

‎src/Symfony/Bundle/FrameworkBundle/Tests/Fixtures/Descriptor/route_1.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
| Host | localhost |
88
| Host Regex | #HOST_REGEX# |
99
| Scheme | http|https |
10-
| Method | GET|HEAD |
10+
| Method | GET|HEAD |
1111
| Requirements | name: [a-z]+ |
1212
| Class | Symfony\Bundle\FrameworkBundle\Tests\Console\Descriptor\RouteStub |
1313
| Defaults | name: Joseph |

‎src/Symfony/Bundle/FrameworkBundle/Tests/Fixtures/Descriptor/route_1_link.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
| Host | localhost |
88
| Host Regex | #HOST_REGEX# |
99
| Scheme | http|https |
10-
| Method | GET|HEAD |
10+
| Method | GET|HEAD |
1111
| Requirements | name: [a-z]+ |
1212
| Class | Symfony\Bundle\FrameworkBundle\Tests\Console\Descriptor\RouteStub |
1313
| Defaults | _controller: ]8;;myeditor://open?file=[:file:]&line=58\Symfony\Bundle\FrameworkBundle\Tests\Console\Descriptor\MyController::__invoke()]8;;\ |

‎src/Symfony/Bundle/FrameworkBundle/Tests/Fixtures/Descriptor/route_2.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
| Host | localhost |
88
| Host Regex | #HOST_REGEX# |
99
| Scheme | http|https |
10-
| Method | PUT|POST |
10+
| Method | PUT|POST |
1111
| Requirements | NO CUSTOM |
1212
| Class | Symfony\Bundle\FrameworkBundle\Tests\Console\Descriptor\RouteStub |
1313
| Defaults | NONE |

0 commit comments

Comments
 (0)