Adding more helpful error messages to the Questionhelper

mamazu · mamazu · commit 9aa3023da142 · 2025-08-02T23:25:46.000+02:00
diff --git a/src/Symfony/Component/Console/Helper/QuestionHelper.php b/src/Symfony/Component/Console/Helper/QuestionHelper.php
@@ -271,7 +271,7 @@ private function autocomplete(OutputInterface $output, Question $question, $inpu
             // as opposed to fgets(), fread() returns an empty string when the stream content is empty, not false.
             if (false === $c || ('' === $ret && '' === $c && null === $question->getDefault())) {
                 shell_exec('stty '.$sttyMode);
-                throw new MissingInputException('Aborted.');
+                throw new MissingInputException('Aborted while asking: '.$question->getQuestion());
             } elseif ("\177" === $c) { // Backspace Character
                 if (0 === $numMatches && 0 !== $i) {
                     --$i;
diff --git a/src/Symfony/Component/Console/Tests/Helper/QuestionHelperTest.php b/src/Symfony/Component/Console/Tests/Helper/QuestionHelperTest.php
@@ -750,7 +750,7 @@ public function testAskThrowsExceptionOnMissingInput()
     public function testAskThrowsExceptionOnMissingInputForChoiceQuestion()
     {
         $this->expectException(MissingInputException::class);
-        $this->expectExceptionMessage('Aborted.');
+        $this->expectExceptionMessage('Aborted while asking: Choice');
         (new QuestionHelper())->ask($this->createStreamableInputInterfaceMock($this->getInputStream('')), $this->createOutputInterface(), new ChoiceQuestion('Choice', ['a', 'b']));
     }
 

Original file line number	Diff line number	Diff line change
`@@ -750,7 +750,7 @@ public function testAskThrowsExceptionOnMissingInput()`
`750`	`750`	`public function testAskThrowsExceptionOnMissingInputForChoiceQuestion()`
`751`	`751`	`{`
`752`	`752`	`$this->expectException(MissingInputException::class);`
`753`		`- $this->expectExceptionMessage('Aborted.');`
	`753`	`+ $this->expectExceptionMessage('Aborted while asking: Choice');`
`754`	`754`	`(new QuestionHelper())->ask($this->createStreamableInputInterfaceMock($this->getInputStream('')), $this->createOutputInterface(), new ChoiceQuestion('Choice', ['a', 'b']));`
`755`	`755`	`}`
`756`	`756`