Removing secret BC Layer in authenticator

ktherage · ktherage · commit 9767a2a3d8f9 · 2025-07-07T11:38:06.000+02:00
diff --git a/src/Symfony/Component/Security/Core/Authentication/Token/RememberMeToken.php b/src/Symfony/Component/Security/Core/Authentication/Token/RememberMeToken.php
@@ -44,7 +44,6 @@ public function getFirewallName(): string
 
     public function __serialize(): array
     {
-        // Newly serialized data removes the secret deprecated since Symfony 7.2 and removed in Symfony 8.0
         return [$this->firewallName, parent::__serialize()];
     }
 
diff --git a/src/Symfony/Component/Security/Http/Authenticator/RememberMeAuthenticator.php b/src/Symfony/Component/Security/Http/Authenticator/RememberMeAuthenticator.php
@@ -43,34 +43,12 @@
  */
 class RememberMeAuthenticator implements InteractiveAuthenticatorInterface
 {
-    private string $secret;
-    private TokenStorageInterface $tokenStorage;
-    private string $cookieName;
-    private ?LoggerInterface $logger;
-
-    /**
-     * @param TokenStorageInterface $tokenStorage
-     * @param string                $cookieName
-     * @param ?LoggerInterface      $logger
-     */
     public function __construct(
         private RememberMeHandlerInterface $rememberMeHandler,
-        #[\SensitiveParameter] TokenStorageInterface|string $tokenStorage,
-        string|TokenStorageInterface $cookieName,
-        LoggerInterface|string|null $logger = null,
+        #[\SensitiveParameter] private TokenStorageInterface $tokenStorage,
+        private string $cookieName,
+        private LoggerInterface|null $logger = null,
     ) {
-        if (\is_string($tokenStorage)) {
-            trigger_deprecation('symfony/security-http', '7.2', 'The "$secret" argument of "%s()" is deprecated.', __METHOD__);
-
-            $this->secret = $tokenStorage;
-            $tokenStorage = $cookieName;
-            $cookieName = $logger;
-            $logger = \func_num_args() > 4 ? func_get_arg(4) : null;
-        }
-
-        $this->tokenStorage = $tokenStorage;
-        $this->cookieName = $cookieName;
-        $this->logger = $logger;
     }
 
     public function supports(Request $request): ?bool
@@ -109,10 +87,6 @@ public function authenticate(Request $request): Passport
 
     public function createToken(Passport $passport, string $firewallName): TokenInterface
     {
-        if (isset($this->secret)) {
-            return new RememberMeToken($passport->getUser(), $firewallName, $this->secret);
-        }
-
         return new RememberMeToken($passport->getUser(), $firewallName);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,6 @@ public function getFirewallName(): string`
`44`	`44`
`45`	`45`	`public function __serialize(): array`
`46`	`46`	`{`
`47`		`- // Newly serialized data removes the secret deprecated since Symfony 7.2 and removed in Symfony 8.0`
`48`	`47`	`return [$this->firewallName, parent::__serialize()];`
`49`	`48`	`}`
`50`	`49`