Spread information about argument's projectDir deprecation

chadyred · chadyred · commit 97354d547d45 · 2025-01-27T09:32:45.000+01:00
diff --git a/UPGRADE-7.3.md b/UPGRADE-7.3.md
@@ -109,3 +109,8 @@ VarDumper
 
  * Deprecate `ResourceCaster::castCurl()`, `ResourceCaster::castGd()` and `ResourceCaster::castOpensslX509()`
  * Mark all casters as `@internal`
+
+AssetMapper
+-----------
+
+ * Deprecated passing null to `ImportMapRequireCommand` constructor argument `projectDir`
diff --git a/src/Symfony/Component/AssetMapper/CHANGELOG.md b/src/Symfony/Component/AssetMapper/CHANGELOG.md
@@ -6,6 +6,7 @@ CHANGELOG
 
  * Add support for pre-compressing assets with Brotli, Zstandard, Zopfli, and gzip
  * Add option `--dry-run` to `importmap:require` command
+ * Deprecated passing null to `ImportMapRequireCommand` constructor argument `projectDir`
 
 7.2
 ---
diff --git a/src/Symfony/Component/AssetMapper/Command/ImportMapRequireCommand.php b/src/Symfony/Component/AssetMapper/Command/ImportMapRequireCommand.php
@@ -33,17 +33,13 @@ final class ImportMapRequireCommand extends Command
 {
     use VersionProblemCommandTrait;
 
-    private readonly string $projectDir;
-
     public function __construct(
         private readonly ImportMapManager $importMapManager,
         private readonly ImportMapVersionChecker $importMapVersionChecker,
-        /* private readonly string $projectDir, */
+        private readonly ?string $projectDir = null,
     ) {
-        if (\func_num_args() < 3) {
+        if (null === $projectDir) {
             trigger_deprecation('symfony/asset-mapper', '7.3', 'The "%s()" method will have a new `string $projectDir` argument in version 8.0, not defining it is deprecated.', __METHOD__);
-        } else {
-            $this->projectDir = func_get_arg(2);
         }
 
         parent::__construct();
