Resolve review comments

bobvandevijver · bobvandevijver · commit 9626d5f31086 · 2022-02-28T10:18:45.000+01:00
diff --git a/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php b/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
@@ -2084,7 +2084,7 @@ private function registerMessengerConfiguration(array $config, ContainerBuilder
         $container->getDefinition('messenger.retry_strategy_locator')
             ->replaceArgument(0, $transportRetryReferences);
 
-        if (empty($transportRateLimiterReferences)) {
+        if (!$transportRateLimiterReferences) {
             $container->removeDefinition('messenger.rate_limiter_locator');
         } else {
             $container->getDefinition('messenger.rate_limiter_locator')
diff --git a/src/Symfony/Bundle/FrameworkBundle/Resources/config/messenger.php b/src/Symfony/Bundle/FrameworkBundle/Resources/config/messenger.php
@@ -161,9 +161,7 @@
 
         // rate limiter
         ->set('messenger.rate_limiter_locator', ServiceLocator::class)
-            ->args([
-                [],
-            ])
+            ->args([[]])
             ->tag('container.service_locator')
 
         // worker event listener
diff --git a/src/Symfony/Component/Messenger/CHANGELOG.md b/src/Symfony/Component/Messenger/CHANGELOG.md
@@ -6,7 +6,7 @@ CHANGELOG
 
  * Add `SerializedMessageStamp` to avoid serializing a message when a retry occurs.
  * Automatically resolve handled message type when method different from `__invoke` is used as handler.
- * Add support for rate limited transports by using the RateLimiter component.
+ * Added support for rate limited transports by using the RateLimiter component.
 
 6.0
 ---
diff --git a/src/Symfony/Component/Messenger/Event/WorkerRateLimitedEvent.php b/src/Symfony/Component/Messenger/Event/WorkerRateLimitedEvent.php
@@ -21,14 +21,8 @@
  */
 final class WorkerRateLimitedEvent
 {
-    private $limiter;
-
-    private $transportName;
-
-    public function __construct(LimiterInterface $limiter, string $transportName)
+    public function __construct(private LimiterInterface $limiter, private string $transportName)
     {
-        $this->limiter = $limiter;
-        $this->transportName = $transportName;
     }
 
     public function getLimiter(): LimiterInterface

Original file line number	Diff line number	Diff line change
`@@ -21,14 +21,8 @@`
`21`	`21`	`*/`
`22`	`22`	`final class WorkerRateLimitedEvent`
`23`	`23`	`{`
`24`		`- private $limiter;`
`25`		`-`
`26`		`- private $transportName;`
`27`		`-`
`28`		`- public function __construct(LimiterInterface $limiter, string $transportName)`
	`24`	`+ public function __construct(private LimiterInterface $limiter, private string $transportName)`
`29`	`25`	`{`
`30`		`- $this->limiter = $limiter;`
`31`		`- $this->transportName = $transportName;`
`32`	`26`	`}`
`33`	`27`
`34`	`28`	`public function getLimiter(): LimiterInterface`