Apply suggestions from code review

valtzu · mtarld · web-flow · commit 95da9eeea886 · 2025-02-03T18:57:40.000+02:00
Co-authored-by: Mathias Arlaud &lt;mathias.arlaud@gmail.com&gt;
diff --git a/src/Symfony/Component/Serializer/Normalizer/NumberNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/NumberNormalizer.php
@@ -30,7 +30,7 @@ public function getSupportedTypes(?string $format): array
     public function normalize(mixed $data, ?string $format = null, array $context = []): string
     {
         if (!$data instanceof Number) {
-            throw new InvalidArgumentException('The data must be an instance of '.Number::class.'.');
+            throw new InvalidArgumentException(\sprintf('The data must be an instance of "%s".', Number::class);
         }
 
         return (string) $data;
@@ -47,17 +47,17 @@ public function supportsNormalization(mixed $data, ?string $format = null, array
     public function denormalize(mixed $data, string $type, ?string $format = null, array $context = []): Number
     {
         if (Number::class !== $type) {
-            throw new InvalidArgumentException('Only '.Number::class.' supported.');
+            throw new InvalidArgumentException(\sprintf('Only "%s" type is supported.', Number::class);
         }
 
         if (!\is_int($data) && !\is_string($data)) {
-            throw NotNormalizableValueException::createForUnexpectedDataType('The data is neither an integer nor a string, you should pass an integer or a string that represents a decimal number.', $data, ['int', 'string'], $context['deserialization_path'] ?? null, true);
+            throw NotNormalizableValueException::createForUnexpectedDataType('The data is neither an "int" nor a "string", you should pass an "int" or a "string" that represents a decimal number.', $data, ['int', 'string'], $context['deserialization_path'] ?? null, true);
         }
 
         try {
             return new Number($data);
         } catch (\ValueError $e) {
-            throw NotNormalizableValueException::createForUnexpectedDataType('The data must represent a decimal number', $data, [$type], $context['deserialization_path'] ?? null, true, 0, $e);
+            throw NotNormalizableValueException::createForUnexpectedDataType('The data must represent a decimal number', $data, ['int', 'string'], $context['deserialization_path'] ?? null, true, 0, $e);
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ public function getSupportedTypes(?string $format): array`
`30`	`30`	`public function normalize(mixed $data, ?string $format = null, array $context = []): string`
`31`	`31`	`{`
`32`	`32`	`if (!$data instanceof Number) {`
`33`		`- throw new InvalidArgumentException('The data must be an instance of '.Number::class.'.');`
	`33`	`+ throw new InvalidArgumentException(\sprintf('The data must be an instance of "%s".', Number::class);`
`34`	`34`	`}`
`35`	`35`
`36`	`36`	`return (string) $data;`
`@@ -47,17 +47,17 @@ public function supportsNormalization(mixed $data, ?string $format = null, array`
`47`	`47`	`public function denormalize(mixed $data, string $type, ?string $format = null, array $context = []): Number`
`48`	`48`	`{`
`49`	`49`	`if (Number::class !== $type) {`
`50`		`- throw new InvalidArgumentException('Only '.Number::class.' supported.');`
	`50`	`+ throw new InvalidArgumentException(\sprintf('Only "%s" type is supported.', Number::class);`
`51`	`51`	`}`
`52`	`52`
`53`	`53`	`if (!\is_int($data) && !\is_string($data)) {`
`54`		`- throw NotNormalizableValueException::createForUnexpectedDataType('The data is neither an integer nor a string, you should pass an integer or a string that represents a decimal number.', $data, ['int', 'string'], $context['deserialization_path'] ?? null, true);`
	`54`	`+ throw NotNormalizableValueException::createForUnexpectedDataType('The data is neither an "int" nor a "string", you should pass an "int" or a "string" that represents a decimal number.', $data, ['int', 'string'], $context['deserialization_path'] ?? null, true);`
`55`	`55`	`}`
`56`	`56`
`57`	`57`	`try {`
`58`	`58`	`return new Number($data);`
`59`	`59`	`} catch (\ValueError $e) {`
`60`		`- throw NotNormalizableValueException::createForUnexpectedDataType('The data must represent a decimal number', $data, [$type], $context['deserialization_path'] ?? null, true, 0, $e);`
	`60`	`+ throw NotNormalizableValueException::createForUnexpectedDataType('The data must represent a decimal number', $data, ['int', 'string'], $context['deserialization_path'] ?? null, true, 0, $e);`
`61`	`61`	`}`
`62`	`62`	`}`
`63`	`63`