[Console] don't discard existing aliases when constructing Command

henderkes · chalasr · commit 917d8d0c1295 · 2025-12-02T01:00:38.000+01:00
diff --git a/src/Symfony/Component/Console/Command/Command.php b/src/Symfony/Component/Console/Command/Command.php
@@ -120,6 +120,12 @@ public function __construct(?string $name = null, ?callable $code = null)
                 $name = array_shift($aliases);
             }
 
+            // we must not overwrite existing aliases, combine new ones with existing ones
+            $aliases = array_unique([
+                ...$this->aliases,
+                ...$aliases,
+            ]);
+
             $this->setAliases($aliases);
         }
 
diff --git a/src/Symfony/Component/Console/Tests/Command/CommandTest.php b/src/Symfony/Component/Console/Tests/Command/CommandTest.php
@@ -199,12 +199,25 @@ public function testGetProcessedHelp()
     public function testGetSetAliases()
     {
         $command = new \TestCommand();
-        $this->assertEquals(['name'], $command->getAliases(), '->getAliases() returns the aliases');
         $ret = $command->setAliases(['name1']);
         $this->assertEquals($command, $ret, '->setAliases() implements a fluent interface');
         $this->assertEquals(['name1'], $command->getAliases(), '->setAliases() sets the aliases');
     }
 
+    public function testAliasesSetBeforeParentConstructorArePreserved()
+    {
+        $command = new class extends Command {
+            public function __construct()
+            {
+                // set aliases before calling parent constructor
+                $this->setAliases(['existingalias']);
+                parent::__construct('foo|newalias');
+            }
+        };
+
+        $this->assertSame(['existingalias', 'newalias'], $command->getAliases(), 'Aliases set before parent::__construct() must be preserved.');
+    }
+
     #[TestWith(['name|alias1|alias2', 'name', ['alias1', 'alias2'], false])]
     #[TestWith(['|alias1|alias2', 'alias1', ['alias2'], true])]
     public function testSetAliasesAndHiddenViaName(string $name, string $expectedName, array $expectedAliases, bool $expectedHidden)

Original file line number	Diff line number	Diff line change
`@@ -120,6 +120,12 @@ public function __construct(?string $name = null, ?callable $code = null)`
`120`	`120`	`$name = array_shift($aliases);`
`121`	`121`	`}`
`122`	`122`
	`123`	`+ // we must not overwrite existing aliases, combine new ones with existing ones`
	`124`	`+ $aliases = array_unique([`
	`125`	`+ ...$this->aliases,`
	`126`	`+ ...$aliases,`
	`127`	`+ ]);`
	`128`	`+`
`123`	`129`	`$this->setAliases($aliases);`
`124`	`130`	`}`
`125`	`131`