replace ucfirst with AbstractString::title()

raffaelecarelle · raffaelecarelle · commit 8bcb63521503 · 2024-11-20T15:23:26.000+01:00
diff --git a/src/Symfony/Component/String/AbstractString.php b/src/Symfony/Component/String/AbstractString.php
@@ -440,9 +440,7 @@ public function kebab(): static
 
     public function pascal(): static
     {
-        $this->string = ucfirst($this->camel());
-
-        return $this;
+        return $this->camel()->title();
     }
 
     abstract public function splice(string $replacement, int $start = 0, ?int $length = null): static;
diff --git a/src/Symfony/Component/String/Tests/AbstractAsciiTestCase.php b/src/Symfony/Component/String/Tests/AbstractAsciiTestCase.php
@@ -1119,16 +1119,7 @@ public static function provideKebab(): array
     }
 
     /**
-     * @testWith ["", ""]
-     *           ["XY", "x_y"]
-     *           ["XuYo", "xu_yo"]
-     *           ["SymfonyIsGreat", "symfony_is_great"]
-     *           ["Symfony5IsGreat", "symfony_5_is_great"]
-     *           ["SymfonyIsGreat", "Symfony is great"]
-     *           ["SYMFONYISGREAT", "SYMFONY_IS_GREAT"]
-     *           ["SymfonyIsAGreatFramework", "Symfony is a great framework"]
-     *           ["SymfonyIsGREAT", "*Symfony* is GREAT!!"]
-     *           ["SYMFONY", "SYMFONY"]
+     * @dataProvider providePascal
      */
     public function testPascal(string $expectedString, string $origin)
     {
@@ -1138,6 +1129,22 @@ public function testPascal(string $expectedString, string $origin)
         $this->assertNotSame($origin, $instance, 'Strings should be immutable');
     }
 
+    public static function providePascal(): array
+    {
+        return [
+            ['', ''],
+            ['XY', 'x_y'],
+            ['XuYo', 'xu_yo'],
+            ['SymfonyIsGreat', 'symfony_is_great'],
+            ['Symfony5IsGreat', 'symfony_5_is_great'],
+            ['SymfonyIsGreat', 'Symfony is great'],
+            ['SYMFONYISGREAT', 'SYMFONY_IS_GREAT'],
+            ['SymfonyIsAGreatFramework', 'Symfony is a great framework'],
+            ['SymfonyIsGREAT', '*Symfony* is GREAT!!'],
+            ['SYMFONY', 'SYMFONY'],
+        ];
+    }
+
     /**
      * @dataProvider provideStartsWith
      */
diff --git a/src/Symfony/Component/String/Tests/AbstractUnicodeTestCase.php b/src/Symfony/Component/String/Tests/AbstractUnicodeTestCase.php
@@ -655,12 +655,24 @@ public static function provideCamel()
         );
     }
 
+    public static function providePascal(): array
+    {
+        return array_merge(
+            parent::providePascal(),
+            [
+                ['SymfonyIstÄußerstCool', 'symfonyIstÄußerstCool'],
+                ['SymfonyWithEmojis', 'Symfony with 😃 emojis'],
+            ]
+        );
+    }
+
     public static function provideSnake()
     {
         return array_merge(
             parent::provideSnake(),
             [
-                ['symfony_ist_äußerst_cool', 'symfonyIstÄußerstCool'],
+                ['symfony-ist-äußerst-cool', 'symfonyIstÄußerstCool'],
+                ['symfony-with-emojis', 'Symfony with 😃 emojis'],
             ]
         );
     }

Original file line number	Diff line number	Diff line change
`@@ -440,9 +440,7 @@ public function kebab(): static`
`440`	`440`
`441`	`441`	`public function pascal(): static`
`442`	`442`	`{`
`443`		`- $this->string = ucfirst($this->camel());`
`444`		`-`
`445`		`- return $this;`
	`443`	`+ return $this->camel()->title();`
`446`	`444`	`}`
`447`	`445`
`448`	`446`	`abstract public function splice(string $replacement, int $start = 0, ?int $length = null): static;`
Original file line number	Diff line number	Diff line change
`@@ -655,12 +655,24 @@ public static function provideCamel()`
`655`	`655`	`);`
`656`	`656`	`}`
`657`	`657`
	`658`	`+ public static function providePascal(): array`
	`659`	`+ {`
	`660`	`+ return array_merge(`
	`661`	`+ parent::providePascal(),`
	`662`	`+ [`
	`663`	`+ ['SymfonyIstÄußerstCool', 'symfonyIstÄußerstCool'],`
	`664`	`+ ['SymfonyWithEmojis', 'Symfony with 😃 emojis'],`
	`665`	`+ ]`
	`666`	`+ );`
	`667`	`+ }`
	`668`	`+`
`658`	`669`	`public static function provideSnake()`
`659`	`670`	`{`
`660`	`671`	`return array_merge(`
`661`	`672`	`parent::provideSnake(),`
`662`	`673`	`[`
`663`		`- ['symfony_ist_äußerst_cool', 'symfonyIstÄußerstCool'],`
	`674`	`+ ['symfony-ist-äußerst-cool', 'symfonyIstÄußerstCool'],`
	`675`	`+ ['symfony-with-emojis', 'Symfony with 😃 emojis'],`
`664`	`676`	`]`
`665`	`677`	`);`
`666`	`678`	`}`