bug #62502 [HttpFoundation] Fix Expires response header for EventStream (4513)

nicolas-grekas · nicolas-grekas · commit 8733b96b8f5f · 2025-11-27T15:27:57.000+01:00
This PR was squashed before being merged into the 7.3 branch. Discussion ---------- [HttpFoundation] Fix Expires response header for EventStream | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | yes | New feature? |no | Deprecations? |no | Issues | - | License | MIT This PR fixes name of the HTTP response header 'Expires' for Event Stream Response, which is currently missing an 's'. Because of the typo, a server may assume that the 'Expires' header is not set and add its own one. There may be an old agents that do not check Cache-Control and only use value of Expires header, leading into incorrect caching of the response. Some servers tend to set Expires value to a future. This fix is applicable to 7.3, 7.4, 8.x. The SSE has not been implemented before 7.3 and is not present in 6.x. One of the responses when using SSE (notice the expire and the expires headers): ``` HTTP/2 200 cache-control: max-age=0, must-revalidate, no-cache, no-store, private x-accel-buffering: no pragma: no-cache expire: 0 date: Mon, 24 Nov 2025 17:01:30 GMT cache-control: max-age=604800 expires: Mon, 01 Dec 2025 17:01:29 GMT content-type: text/event-stream; charset=UTF-8 server: Apache ... ``` *WIP: Missing tests* Commits ------- b830108 [HttpFoundation] Fix Expires response header for EventStream
diff --git a/src/Symfony/Component/HttpFoundation/EventStreamResponse.php b/src/Symfony/Component/HttpFoundation/EventStreamResponse.php
@@ -48,7 +48,7 @@ public function __construct(?callable $callback = null, int $status = 200, array
             'Cache-Control' => 'private, no-cache, no-store, must-revalidate, max-age=0',
             'X-Accel-Buffering' => 'no',
             'Pragma' => 'no-cache',
-            'Expire' => '0',
+            'Expires' => '0',
         ];
 
         parent::__construct($callback, $status, $headers);
diff --git a/src/Symfony/Component/HttpFoundation/Tests/EventStreamResponseTest.php b/src/Symfony/Component/HttpFoundation/Tests/EventStreamResponseTest.php
@@ -29,6 +29,14 @@ public function testInitializationWithDefaultValues()
         $this->assertNull($response->getRetry());
     }
 
+    public function testPresentOfExpiresHeader()
+    {
+        $response = new EventStreamResponse();
+
+        $this->assertTrue($response->headers->has('Expires'));
+        $this->assertSame('0', $response->headers->get('Expires'));
+    }
+
     public function testStreamSingleEvent()
     {
         $response = new EventStreamResponse(function () {

Original file line number	Diff line number	Diff line change
`@@ -29,6 +29,14 @@ public function testInitializationWithDefaultValues()`
`29`	`29`	`$this->assertNull($response->getRetry());`
`30`	`30`	`}`
`31`	`31`
	`32`	`+ public function testPresentOfExpiresHeader()`
	`33`	`+ {`
	`34`	`+ $response = new EventStreamResponse();`
	`35`	`+`
	`36`	`+ $this->assertTrue($response->headers->has('Expires'));`
	`37`	`+ $this->assertSame('0', $response->headers->get('Expires'));`
	`38`	`+ }`
	`39`	`+`
`32`	`40`	`public function testStreamSingleEvent()`
`33`	`41`	`{`
`34`	`42`	`$response = new EventStreamResponse(function () {`