bug #27264 [Validator] Use strict type in URL validator (mimol91)

fabpot · fabpot · commit 81cef4b77492 · 2018-05-18T04:00:55.000+02:00
This PR was merged into the 3.4 branch. Discussion ---------- [Validator] Use strict type in URL validator | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes Fixed tickets | - | License | MIT | Doc PR | - Using `checkDNS` option with value `true` generate error `Warning: checkdnsrr(): Type '1' not supported`. In SF 3.4 it was mark as depreciation and silently converted to `ANY` https://github.com/symfony/symfony/blob/v3.4.9/src/Symfony/Component/Validator/Constraints/UrlValidator.php#L79 ~~Test are failing on `Symfony\Component\HttpKernel\Tests\ControllerMetadata\ArgumentMetadataFactoryTest::testSignature1` - I think its not related~~ Commits ------- 2400e71 use strict compare in url validator
diff --git a/src/Symfony/Component/Validator/Constraints/UrlValidator.php b/src/Symfony/Component/Validator/Constraints/UrlValidator.php
@@ -92,7 +92,7 @@ public function validate($value, Constraint $constraint)
                 Url::CHECK_DNS_TYPE_SOA,
                 Url::CHECK_DNS_TYPE_SRV,
                 Url::CHECK_DNS_TYPE_TXT,
-            ))) {
+            ), true)) {
                 throw new InvalidOptionsException(sprintf('Invalid value for option "checkDNS" in constraint %s', get_class($constraint)), array('checkDNS'));
             }
 

Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,7 @@ public function validate($value, Constraint $constraint)`
`92`	`92`	`Url::CHECK_DNS_TYPE_SOA,`
`93`	`93`	`Url::CHECK_DNS_TYPE_SRV,`
`94`	`94`	`Url::CHECK_DNS_TYPE_TXT,`
`95`		`- ))) {`
	`95`	`+ ), true)) {`
`96`	`96`	`throw new InvalidOptionsException(sprintf('Invalid value for option "checkDNS" in constraint %s', get_class($constraint)), array('checkDNS'));`
`97`	`97`	`}`
`98`	`98`