feature #60876 [HttpFoundation] Deprecate using Request::sendHeaders() after headers have already been sent (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit 7db556d3d680 · 2025-06-23T17:18:21.000+02:00
This PR was merged into the 7.4 branch. Discussion ---------- [HttpFoundation] Deprecate using `Request::sendHeaders()` after headers have already been sent | Q | A | ------------- | --- | Branch? | 7.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT Sibling to #60875 to account for #60603 Commits ------- 6f6fdf0 [HttpFoundation] Deprecate using `Request::sendHeaders()` after headers have already been sent
diff --git a/UPGRADE-7.4.md b/UPGRADE-7.4.md
@@ -22,3 +22,8 @@ HttpClient
 ----------
 
  * Deprecate using amphp/http-client < 5
+
+HttpFoundation
+--------------
+
+ * Deprecate using `Request::sendHeaders()` after headers have already been sent; use a `StreamedResponse` instead
diff --git a/src/Symfony/Component/HttpFoundation/CHANGELOG.md b/src/Symfony/Component/HttpFoundation/CHANGELOG.md
@@ -1,6 +1,11 @@
 CHANGELOG
 =========
 
+7.4
+---
+
+ * Deprecate using `Request::sendHeaders()` after headers have already been sent; use a `StreamedResponse` instead
+
 7.3
 ---
 
diff --git a/src/Symfony/Component/HttpFoundation/Response.php b/src/Symfony/Component/HttpFoundation/Response.php
@@ -319,7 +319,8 @@ public function sendHeaders(?int $statusCode = null): static
         if (headers_sent()) {
             if (!\in_array(\PHP_SAPI, ['cli', 'phpdbg', 'embed'], true)) {
                 $statusCode ??= $this->statusCode;
-                header(\sprintf('HTTP/%s %s %s', $this->version, $statusCode, $this->statusText), true, $statusCode);
+                trigger_deprecation('symfony/http-foundation', '7.4', 'Trying to use "%s::sendHeaders()" after headers have already been sent is deprecated will throw a PHP warning in 8.0. Use a "StreamedResponse" instead.', static::class);
+                //header(\sprintf('HTTP/%s %s %s', $this->version, $statusCode, $this->statusText), true, $statusCode);
             }
 
             return $this;

Original file line number	Diff line number	Diff line change
`@@ -319,7 +319,8 @@ public function sendHeaders(?int $statusCode = null): static`
`319`	`319`	`if (headers_sent()) {`
`320`	`320`	`if (!\in_array(\PHP_SAPI, ['cli', 'phpdbg', 'embed'], true)) {`
`321`	`321`	`$statusCode ??= $this->statusCode;`
`322`		`- header(\sprintf('HTTP/%s %s %s', $this->version, $statusCode, $this->statusText), true, $statusCode);`
	`322`	`+ trigger_deprecation('symfony/http-foundation', '7.4', 'Trying to use "%s::sendHeaders()" after headers have already been sent is deprecated will throw a PHP warning in 8.0. Use a "StreamedResponse" instead.', static::class);`
	`323`	`+ //header(\sprintf('HTTP/%s %s %s', $this->version, $statusCode, $this->statusText), true, $statusCode);`
`323`	`324`	`}`
`324`	`325`
`325`	`326`	`return $this;`