minor #46844 [HttpKernel] remove else logic (Nil Borodulia)

nicolas-grekas · nicolas-grekas · commit 7c194b9c4cd8 · 2022-07-11T08:21:11.000+02:00
This PR was merged into the 6.2 branch. Discussion ---------- [HttpKernel] remove else logic | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | none | License | MIT | Doc PR | none Refactoring. Removed else logic for more understanding. Commits ------- 3ad51d7 remove else logic
diff --git a/src/Symfony/Component/HttpKernel/UriSigner.php b/src/Symfony/Component/HttpKernel/UriSigner.php
@@ -42,10 +42,10 @@ public function __construct(string $secret, string $parameter = '_hash')
     public function sign(string $uri): string
     {
         $url = parse_url($uri);
+        $params = [];
+
         if (isset($url['query'])) {
             parse_str($url['query'], $params);
-        } else {
-            $params = [];
         }
 
         $uri = $this->buildUrl($url, $params);
@@ -60,10 +60,10 @@ public function sign(string $uri): string
     public function check(string $uri): bool
     {
         $url = parse_url($uri);
+        $params = [];
+
         if (isset($url['query'])) {
             parse_str($url['query'], $params);
-        } else {
-            $params = [];
         }
 
         if (empty($params[$this->parameter])) {
@@ -101,7 +101,7 @@ private function buildUrl(array $url, array $params = []): string
         $pass = isset($url['pass']) ? ':'.$url['pass'] : '';
         $pass = ($user || $pass) ? "$pass@" : '';
         $path = $url['path'] ?? '';
-        $query = isset($url['query']) && $url['query'] ? '?'.$url['query'] : '';
+        $query = $url['query'] ? '?'.$url['query'] : '';
         $fragment = isset($url['fragment']) ? '#'.$url['fragment'] : '';
 
         return $scheme.$user.$pass.$host.$port.$path.$query.$fragment;
