bug #19204 [Security] Allow LDAP loadUser override (tucksaun)

fabpot · fabpot · commit 7b2af2d660ea · 2016-06-29T07:10:15.000+02:00
This PR was merged into the 3.1 branch. Discussion ---------- [Security] Allow LDAP loadUser override | Q | A | ------------- | --- | Branch? | 3.1 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Back to 3.0, one could extend `Symfony\Component\Security\Core\User\LdapUserProvider` and override how User objects are created. Among several improvements, #17560 changed `loadUser` signature but also visibility to `private` which disallow any overriding. Even if the signature BC break is legitimate, we should still be able to override this method IMHO, which is not possible with a private visibility. This PRs introduces a `protected` visibility to allow again overriding. Commits ------- ae99aa8 [Security] Allow LDAP loadUser override
diff --git a/src/Symfony/Component/Security/Core/User/LdapUserProvider.php b/src/Symfony/Component/Security/Core/User/LdapUserProvider.php
@@ -111,7 +111,7 @@ public function supportsClass($class)
      *
      * @return User
      */
-    private function loadUser($username, Entry $entry)
+    protected function loadUser($username, Entry $entry)
     {
         $password = $this->getPassword($entry);
 

Original file line number	Diff line number	Diff line change
`@@ -111,7 +111,7 @@ public function supportsClass($class)`
`111`	`111`	`*`
`112`	`112`	`* @return User`
`113`	`113`	`*/`
`114`		`- private function loadUser($username, Entry $entry)`
	`114`	`+ protected function loadUser($username, Entry $entry)`
`115`	`115`	`{`
`116`	`116`	`$password = $this->getPassword($entry);`
`117`	`117`