PHP CS Fixer: enable random_api_migration

keradus · nicolas-grekas · commit 7a806bf6b489 · 2025-12-19T09:37:21.000+01:00
diff --git a/.php-cs-fixer.dist.php b/.php-cs-fixer.dist.php
@@ -46,6 +46,7 @@
             ]),
         ],
         'php_unit_attributes' => true,
+        'random_api_migration' => true,
         // 'static_lambda' => true, // @todo @keradus to fix last issues
     ])
     ->setRiskyAllowed(true)
diff --git a/src/Symfony/Component/Cache/Tests/Adapter/ProxyAdapterAndRedisAdapterTest.php b/src/Symfony/Component/Cache/Tests/Adapter/ProxyAdapterAndRedisAdapterTest.php
@@ -50,7 +50,7 @@ static function (CacheItem $item, $expiry) {
 
         $cache = $this->createCachePool(1);
         $cache->clear();
-        $value = rand();
+        $value = random_int(0, getrandmax());
         $item = $cache->getItem('foo');
         $setCacheItemExpiry($item, 0);
         $cache->save($item->set($value));
diff --git a/src/Symfony/Component/Config/Tests/Resource/DirectoryResourceTest.php b/src/Symfony/Component/Config/Tests/Resource/DirectoryResourceTest.php
@@ -67,7 +67,7 @@ public function testResourceDoesNotExist()
     {
         $this->expectException(\InvalidArgumentException::class);
         $this->expectExceptionMessageMatches('/The directory ".*" does not exist./');
-        new DirectoryResource('/____foo/foobar'.mt_rand(1, 999999));
+        new DirectoryResource('/____foo/foobar'.random_int(1, 999999));
     }
 
     public function testIsFresh()
diff --git a/src/Symfony/Component/Config/Tests/Resource/FileResourceTest.php b/src/Symfony/Component/Config/Tests/Resource/FileResourceTest.php
@@ -55,7 +55,7 @@ public function testResourceDoesNotExist()
     {
         $this->expectException(\InvalidArgumentException::class);
         $this->expectExceptionMessageMatches('/The file ".*" does not exist./');
-        new FileResource('/____foo/foobar'.mt_rand(1, 999999));
+        new FileResource('/____foo/foobar'.random_int(1, 999999));
     }
 
     public function testIsFresh()
diff --git a/src/Symfony/Component/Filesystem/Tests/FilesystemTest.php b/src/Symfony/Component/Filesystem/Tests/FilesystemTest.php
@@ -662,7 +662,7 @@ public function testChownSymlinkFails()
 
         $this->filesystem->symlink($file, $link);
 
-        $this->filesystem->chown($link, 'user'.time().mt_rand(1000, 9999));
+        $this->filesystem->chown($link, 'user'.time().random_int(1000, 9999));
     }
 
     public function testChownLinkFails()
@@ -677,7 +677,7 @@ public function testChownLinkFails()
 
         $this->filesystem->hardlink($file, $link);
 
-        $this->filesystem->chown($link, 'user'.time().mt_rand(1000, 9999));
+        $this->filesystem->chown($link, 'user'.time().random_int(1000, 9999));
     }
 
     public function testChownFail()
@@ -688,7 +688,7 @@ public function testChownFail()
         $dir = $this->workspace.\DIRECTORY_SEPARATOR.'dir';
         mkdir($dir);
 
-        $this->filesystem->chown($dir, 'user'.time().mt_rand(1000, 9999));
+        $this->filesystem->chown($dir, 'user'.time().random_int(1000, 9999));
     }
 
     public function testChgrpByName()
@@ -795,7 +795,7 @@ public function testChgrpSymlinkFails()
 
         $this->filesystem->symlink($file, $link);
 
-        $this->filesystem->chgrp($link, 'user'.time().mt_rand(1000, 9999));
+        $this->filesystem->chgrp($link, 'user'.time().random_int(1000, 9999));
     }
 
     public function testChgrpLinkFails()
@@ -810,7 +810,7 @@ public function testChgrpLinkFails()
 
         $this->filesystem->hardlink($file, $link);
 
-        $this->filesystem->chgrp($link, 'user'.time().mt_rand(1000, 9999));
+        $this->filesystem->chgrp($link, 'user'.time().random_int(1000, 9999));
     }
 
     public function testChgrpFail()
@@ -821,7 +821,7 @@ public function testChgrpFail()
         $dir = $this->workspace.\DIRECTORY_SEPARATOR.'dir';
         mkdir($dir);
 
-        $this->filesystem->chgrp($dir, 'user'.time().mt_rand(1000, 9999));
+        $this->filesystem->chgrp($dir, 'user'.time().random_int(1000, 9999));
     }
 
     public function testRename()
diff --git a/src/Symfony/Component/Form/Tests/Extension/Core/Type/ChoiceTypePerformanceTest.php b/src/Symfony/Component/Form/Tests/Extension/Core/Type/ChoiceTypePerformanceTest.php
@@ -30,7 +30,7 @@ public function testSameChoiceFieldCreatedMultipleTimes()
         $choices = range(1, 300);
 
         for ($i = 0; $i < 100; ++$i) {
-            $this->factory->create('Symfony\Component\Form\Extension\Core\Type\ChoiceType', mt_rand(1, 400), [
+            $this->factory->create('Symfony\Component\Form\Extension\Core\Type\ChoiceType', random_int(1, 400), [
                 'choices' => $choices,
             ]);
         }
diff --git a/src/Symfony/Component/HttpKernel/Profiler/FileProfilerStorage.php b/src/Symfony/Component/HttpKernel/Profiler/FileProfilerStorage.php
@@ -189,7 +189,7 @@ public function write(Profile $profile): bool
             ], ',', '"', '\\');
             fclose($file);
 
-            if (1 === mt_rand(1, 10)) {
+            if (1 === random_int(1, 10)) {
                 $this->removeExpiredProfiles();
             }
         }
diff --git a/src/Symfony/Component/Intl/Tests/Data/Bundle/Writer/JsonBundleWriterTest.php b/src/Symfony/Component/Intl/Tests/Data/Bundle/Writer/JsonBundleWriterTest.php
@@ -28,7 +28,7 @@ class JsonBundleWriterTest extends TestCase
     protected function setUp(): void
     {
         $this->writer = new JsonBundleWriter();
-        $this->directory = sys_get_temp_dir().'/JsonBundleWriterTest/'.mt_rand(1000, 9999);
+        $this->directory = sys_get_temp_dir().'/JsonBundleWriterTest/'.random_int(1000, 9999);
         $this->filesystem = new Filesystem();
 
         $this->filesystem->mkdir($this->directory);
diff --git a/src/Symfony/Component/Intl/Tests/Data/Bundle/Writer/PhpBundleWriterTest.php b/src/Symfony/Component/Intl/Tests/Data/Bundle/Writer/PhpBundleWriterTest.php
@@ -28,7 +28,7 @@ class PhpBundleWriterTest extends TestCase
     protected function setUp(): void
     {
         $this->writer = new PhpBundleWriter();
-        $this->directory = sys_get_temp_dir().'/PhpBundleWriterTest/'.mt_rand(1000, 9999);
+        $this->directory = sys_get_temp_dir().'/PhpBundleWriterTest/'.random_int(1000, 9999);
         $this->filesystem = new Filesystem();
 
         $this->filesystem->mkdir($this->directory);
diff --git a/src/Symfony/Component/Intl/Tests/Data/Bundle/Writer/TextBundleWriterTest.php b/src/Symfony/Component/Intl/Tests/Data/Bundle/Writer/TextBundleWriterTest.php
@@ -29,7 +29,7 @@ class TextBundleWriterTest extends TestCase
     protected function setUp(): void
     {
         $this->writer = new TextBundleWriter();
-        $this->directory = sys_get_temp_dir().'/TextBundleWriterTest/'.mt_rand(1000, 9999);
+        $this->directory = sys_get_temp_dir().'/TextBundleWriterTest/'.random_int(1000, 9999);
         $this->filesystem = new Filesystem();
 
         $this->filesystem->mkdir($this->directory);
diff --git a/src/Symfony/Component/Intl/Tests/Data/Util/LocaleScannerTest.php b/src/Symfony/Component/Intl/Tests/Data/Util/LocaleScannerTest.php
@@ -26,7 +26,7 @@ class LocaleScannerTest extends TestCase
 
     protected function setUp(): void
     {
-        $this->directory = sys_get_temp_dir().'/LocaleScannerTest/'.mt_rand(1000, 9999);
+        $this->directory = sys_get_temp_dir().'/LocaleScannerTest/'.random_int(1000, 9999);
         $this->filesystem = new Filesystem();
         $this->scanner = new LocaleScanner();
 
diff --git a/src/Symfony/Component/Mailer/Transport/RoundRobinTransport.php b/src/Symfony/Component/Mailer/Transport/RoundRobinTransport.php
@@ -112,7 +112,7 @@ protected function getInitialCursor(): int
     {
         // the cursor initial value is randomized so that
         // when are not in a daemon, we are still rotating the transports
-        return mt_rand(0, \count($this->transports) - 1);
+        return random_int(0, \count($this->transports) - 1);
     }
 
     protected function getNameSymbol(): string
diff --git a/src/Symfony/Component/Notifier/Transport/RoundRobinTransport.php b/src/Symfony/Component/Notifier/Transport/RoundRobinTransport.php
@@ -127,7 +127,7 @@ protected function getInitialCursor(): int
     {
         // the cursor initial value is randomized so that
         // when are not in a daemon, we are still rotating the transports
-        return mt_rand(0, \count($this->transports) - 1);
+        return random_int(0, \count($this->transports) - 1);
     }
 
     protected function getNameSymbol(): string
diff --git a/src/Symfony/Component/Translation/PseudoLocalizationTranslator.php b/src/Symfony/Component/Translation/PseudoLocalizationTranslator.php
@@ -382,3 +382,5 @@ private function strlen(string $s): int
         return false === ($encoding = mb_detect_encoding($s, null, true)) ? \strlen($s) : mb_strlen($s, $encoding);
     }
 }
+
+// @php-cs-fixer-ignore random_api_migration As logic is coupled with mt_srand() in tests

Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ public function testResourceDoesNotExist()`
`67`	`67`	`{`
`68`	`68`	`$this->expectException(\InvalidArgumentException::class);`
`69`	`69`	`$this->expectExceptionMessageMatches('/The directory ".*" does not exist./');`
`70`		`- new DirectoryResource('/____foo/foobar'.mt_rand(1, 999999));`
	`70`	`+ new DirectoryResource('/____foo/foobar'.random_int(1, 999999));`
`71`	`71`	`}`
`72`	`72`
`73`	`73`	`public function testIsFresh()`
Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ public function testResourceDoesNotExist()`
`55`	`55`	`{`
`56`	`56`	`$this->expectException(\InvalidArgumentException::class);`
`57`	`57`	`$this->expectExceptionMessageMatches('/The file ".*" does not exist./');`
`58`		`- new FileResource('/____foo/foobar'.mt_rand(1, 999999));`
	`58`	`+ new FileResource('/____foo/foobar'.random_int(1, 999999));`
`59`	`59`	`}`
`60`	`60`
`61`	`61`	`public function testIsFresh()`
Original file line number	Diff line number	Diff line change
`@@ -662,7 +662,7 @@ public function testChownSymlinkFails()`
`662`	`662`
`663`	`663`	`$this->filesystem->symlink($file, $link);`
`664`	`664`
`665`		`- $this->filesystem->chown($link, 'user'.time().mt_rand(1000, 9999));`
	`665`	`+ $this->filesystem->chown($link, 'user'.time().random_int(1000, 9999));`
`666`	`666`	`}`
`667`	`667`
`668`	`668`	`public function testChownLinkFails()`
`@@ -677,7 +677,7 @@ public function testChownLinkFails()`
`677`	`677`
`678`	`678`	`$this->filesystem->hardlink($file, $link);`
`679`	`679`
`680`		`- $this->filesystem->chown($link, 'user'.time().mt_rand(1000, 9999));`
	`680`	`+ $this->filesystem->chown($link, 'user'.time().random_int(1000, 9999));`
`681`	`681`	`}`
`682`	`682`
`683`	`683`	`public function testChownFail()`
`@@ -688,7 +688,7 @@ public function testChownFail()`
`688`	`688`	`$dir = $this->workspace.\DIRECTORY_SEPARATOR.'dir';`
`689`	`689`	`mkdir($dir);`
`690`	`690`
`691`		`- $this->filesystem->chown($dir, 'user'.time().mt_rand(1000, 9999));`
	`691`	`+ $this->filesystem->chown($dir, 'user'.time().random_int(1000, 9999));`
`692`	`692`	`}`
`693`	`693`
`694`	`694`	`public function testChgrpByName()`
`@@ -795,7 +795,7 @@ public function testChgrpSymlinkFails()`
`795`	`795`
`796`	`796`	`$this->filesystem->symlink($file, $link);`
`797`	`797`
`798`		`- $this->filesystem->chgrp($link, 'user'.time().mt_rand(1000, 9999));`
	`798`	`+ $this->filesystem->chgrp($link, 'user'.time().random_int(1000, 9999));`
`799`	`799`	`}`
`800`	`800`
`801`	`801`	`public function testChgrpLinkFails()`
`@@ -810,7 +810,7 @@ public function testChgrpLinkFails()`
`810`	`810`
`811`	`811`	`$this->filesystem->hardlink($file, $link);`
`812`	`812`
`813`		`- $this->filesystem->chgrp($link, 'user'.time().mt_rand(1000, 9999));`
	`813`	`+ $this->filesystem->chgrp($link, 'user'.time().random_int(1000, 9999));`
`814`	`814`	`}`
`815`	`815`
`816`	`816`	`public function testChgrpFail()`
`@@ -821,7 +821,7 @@ public function testChgrpFail()`
`821`	`821`	`$dir = $this->workspace.\DIRECTORY_SEPARATOR.'dir';`
`822`	`822`	`mkdir($dir);`
`823`	`823`
`824`		`- $this->filesystem->chgrp($dir, 'user'.time().mt_rand(1000, 9999));`
	`824`	`+ $this->filesystem->chgrp($dir, 'user'.time().random_int(1000, 9999));`
`825`	`825`	`}`
`826`	`826`
`827`	`827`	`public function testRename()`
Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ public function testSameChoiceFieldCreatedMultipleTimes()`
`30`	`30`	`$choices = range(1, 300);`
`31`	`31`
`32`	`32`	`for ($i = 0; $i < 100; ++$i) {`
`33`		`- $this->factory->create('Symfony\Component\Form\Extension\Core\Type\ChoiceType', mt_rand(1, 400), [`
	`33`	`+ $this->factory->create('Symfony\Component\Form\Extension\Core\Type\ChoiceType', random_int(1, 400), [`
`34`	`34`	`'choices' => $choices,`
`35`	`35`	`]);`
`36`	`36`	`}`
Original file line number	Diff line number	Diff line change
`@@ -189,7 +189,7 @@ public function write(Profile $profile): bool`
`189`	`189`	`], ',', '"', '\\');`
`190`	`190`	`fclose($file);`
`191`	`191`
`192`		`- if (1 === mt_rand(1, 10)) {`
	`192`	`+ if (1 === random_int(1, 10)) {`
`193`	`193`	`$this->removeExpiredProfiles();`
`194`	`194`	`}`
`195`	`195`	`}`
Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ class JsonBundleWriterTest extends TestCase`
`28`	`28`	`protected function setUp(): void`
`29`	`29`	`{`
`30`	`30`	`$this->writer = new JsonBundleWriter();`
`31`		`- $this->directory = sys_get_temp_dir().'/JsonBundleWriterTest/'.mt_rand(1000, 9999);`
	`31`	`+ $this->directory = sys_get_temp_dir().'/JsonBundleWriterTest/'.random_int(1000, 9999);`
`32`	`32`	`$this->filesystem = new Filesystem();`
`33`	`33`
`34`	`34`	`$this->filesystem->mkdir($this->directory);`
Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ class PhpBundleWriterTest extends TestCase`
`28`	`28`	`protected function setUp(): void`
`29`	`29`	`{`
`30`	`30`	`$this->writer = new PhpBundleWriter();`
`31`		`- $this->directory = sys_get_temp_dir().'/PhpBundleWriterTest/'.mt_rand(1000, 9999);`
	`31`	`+ $this->directory = sys_get_temp_dir().'/PhpBundleWriterTest/'.random_int(1000, 9999);`
`32`	`32`	`$this->filesystem = new Filesystem();`
`33`	`33`
`34`	`34`	`$this->filesystem->mkdir($this->directory);`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ class TextBundleWriterTest extends TestCase`
`29`	`29`	`protected function setUp(): void`
`30`	`30`	`{`
`31`	`31`	`$this->writer = new TextBundleWriter();`
`32`		`- $this->directory = sys_get_temp_dir().'/TextBundleWriterTest/'.mt_rand(1000, 9999);`
	`32`	`+ $this->directory = sys_get_temp_dir().'/TextBundleWriterTest/'.random_int(1000, 9999);`
`33`	`33`	`$this->filesystem = new Filesystem();`
`34`	`34`
`35`	`35`	`$this->filesystem->mkdir($this->directory);`