feature #25290 [FrameworkBundle] debug:autowiring: don't list FQCN when they are aliased (nicolas-grekas)

fabpot · fabpot · commit 7744e8f802a1 · 2017-12-07T18:46:54.000-08:00
This PR was merged into the 4.1-dev branch. Discussion ---------- [FrameworkBundle] debug:autowiring: don't list FQCN when they are aliased | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - In order to favor type-hinting for interfaces, I propose to not list the class as explicitly autowireable when an alias exists for it. Which means displaying only ``` App\FooInterface alias to App\Foo ``` instead of ``` App\Foo App\FooInterface alias to App\Foo ``` ping @weaverryan Commits ------- 8cbfa1e [FrameworkBundle] debug:autowiring: don't list FQCN when they are aliased
diff --git a/src/Symfony/Bundle/FrameworkBundle/Command/DebugAutowiringCommand.php b/src/Symfony/Bundle/FrameworkBundle/Command/DebugAutowiringCommand.php
@@ -85,13 +85,17 @@ protected function execute(InputInterface $input, OutputInterface $output)
         }
         $io->newLine();
         $tableRows = array();
+        $hasAlias = array();
         foreach ($serviceIds as $serviceId) {
-            $tableRows[] = array(sprintf('<fg=cyan>%s</fg=cyan>', $serviceId));
             if ($builder->hasAlias($serviceId)) {
+                $tableRows[] = array(sprintf('<fg=cyan>%s</fg=cyan>', $serviceId));
                 $tableRows[] = array(sprintf('    alias to %s', $builder->getAlias($serviceId)));
+                $hasAlias[(string) $builder->getAlias($serviceId)] = true;
+            } else {
+                $tableRows[$serviceId] = array(sprintf('<fg=cyan>%s</fg=cyan>', $serviceId));
             }
         }
 
-        $io->table(array(), $tableRows);
+        $io->table(array(), array_diff_key($tableRows, $hasAlias));
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -85,13 +85,17 @@ protected function execute(InputInterface $input, OutputInterface $output)`
`85`	`85`	`}`
`86`	`86`	`$io->newLine();`
`87`	`87`	`$tableRows = array();`
	`88`	`+ $hasAlias = array();`
`88`	`89`	`foreach ($serviceIds as $serviceId) {`
`89`		`- $tableRows[] = array(sprintf('<fg=cyan>%s</fg=cyan>', $serviceId));`
`90`	`90`	`if ($builder->hasAlias($serviceId)) {`
	`91`	`+ $tableRows[] = array(sprintf('<fg=cyan>%s</fg=cyan>', $serviceId));`
`91`	`92`	`$tableRows[] = array(sprintf(' alias to %s', $builder->getAlias($serviceId)));`
	`93`	`+ $hasAlias[(string) $builder->getAlias($serviceId)] = true;`
	`94`	`+ } else {`
	`95`	`+ $tableRows[$serviceId] = array(sprintf('<fg=cyan>%s</fg=cyan>', $serviceId));`
`92`	`96`	`}`
`93`	`97`	`}`
`94`	`98`
`95`		`- $io->table(array(), $tableRows);`
	`99`	`+ $io->table(array(), array_diff_key($tableRows, $hasAlias));`
`96`	`100`	`}`
`97`	`101`	`}`