[Mime] Fix case-sensitive handling in Headers::addHeader()

piku235 · piku235 · commit 70f703dd9a62 · 2021-01-23T18:24:24.000+01:00
diff --git a/src/Symfony/Component/Mime/Header/Headers.php b/src/Symfony/Component/Mime/Header/Headers.php
@@ -143,7 +143,7 @@ public function addParameterizedHeader(string $name, string $value, array $param
      */
     public function addHeader(string $name, $argument, array $more = []): self
     {
-        $parts = explode('\\', self::HEADER_CLASS_MAP[$name] ?? UnstructuredHeader::class);
+        $parts = explode('\\', self::HEADER_CLASS_MAP[strtolower($name)] ?? UnstructuredHeader::class);
         $method = 'add'.ucfirst(array_pop($parts));
         if ('addUnstructuredHeader' === $method) {
             $method = 'addTextHeader';
diff --git a/src/Symfony/Component/Mime/Tests/Header/HeadersTest.php b/src/Symfony/Component/Mime/Tests/Header/HeadersTest.php
@@ -239,6 +239,15 @@ public function testRemoveIsNotCaseSensitive()
         $this->assertFalse($headers->has('Message-ID'));
     }
 
+    public function testAddHeaderIsNotCaseSensitive()
+    {
+        $headers = new Headers();
+        $headers->addHeader('From', ['from@example.com']);
+
+        $this->assertInstanceOf(MailboxListHeader::class, $headers->get('from'));
+        $this->assertEquals([new Address('from@example.com')], $headers->get('from')->getBody());
+    }
+
     public function testToStringJoinsHeadersTogether()
     {
         $headers = new Headers();

Original file line number	Diff line number	Diff line change
`@@ -143,7 +143,7 @@ public function addParameterizedHeader(string $name, string $value, array $param`
`143`	`143`	`*/`
`144`	`144`	`public function addHeader(string $name, $argument, array $more = []): self`
`145`	`145`	`{`
`146`		`- $parts = explode('\\', self::HEADER_CLASS_MAP[$name] ?? UnstructuredHeader::class);`
	`146`	`+ $parts = explode('\\', self::HEADER_CLASS_MAP[strtolower($name)] ?? UnstructuredHeader::class);`
`147`	`147`	`$method = 'add'.ucfirst(array_pop($parts));`
`148`	`148`	`if ('addUnstructuredHeader' === $method) {`
`149`	`149`	`$method = 'addTextHeader';`