minor #28037 [Form] fix truncating form views in data collector (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit 707e52afd7ee · 2018-07-23T16:49:37.000+02:00
This PR was merged into the 3.4 branch. Discussion ---------- [Form] fix truncating form views in data collector | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no (fixing a non released patch) | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Fixes #27923. Commits ------- 5fa1f12 [Form] fix truncating form views in data collector
diff --git a/src/Symfony/Component/Form/Extension/DataCollector/FormDataCollector.php b/src/Symfony/Component/Form/Extension/DataCollector/FormDataCollector.php
@@ -19,6 +19,7 @@
 use Symfony\Component\Validator\ConstraintViolationInterface;
 use Symfony\Component\VarDumper\Caster\Caster;
 use Symfony\Component\VarDumper\Caster\ClassStub;
+use Symfony\Component\VarDumper\Caster\StubCaster;
 use Symfony\Component\VarDumper\Cloner\Stub;
 
 /**
@@ -262,6 +263,7 @@ protected function getCasters()
                     Caster::PREFIX_VIRTUAL.'type_class' => new ClassStub(get_class($f->getConfig()->getType()->getInnerType())),
                 );
             },
+            FormView::class => array(StubCaster::class, 'cutInternals'),
             ConstraintViolationInterface::class => function (ConstraintViolationInterface $v, array $a) {
                 return array(
                     Caster::PREFIX_VIRTUAL.'root' => $v->getRoot(),
diff --git a/src/Symfony/Component/Form/Extension/DataCollector/FormDataExtractor.php b/src/Symfony/Component/Form/Extension/DataCollector/FormDataExtractor.php
@@ -15,7 +15,6 @@
 use Symfony\Component\Form\FormView;
 use Symfony\Component\HttpKernel\DataCollector\Util\ValueExporter;
 use Symfony\Component\Validator\ConstraintViolationInterface;
-use Symfony\Component\VarDumper\Caster\CutStub;
 
 /**
  * Default implementation of {@link FormDataExtractorInterface}.
@@ -156,10 +155,6 @@ public function extractViewVariables(FormView $view)
         );
 
         foreach ($view->vars as $varName => $value) {
-            // Removing redundant variable from view variables
-            if ('form' === $varName) {
-                $value = new CutStub($value);
-            }
             $data['view_vars'][$varName] = $value;
         }
 
