feature #37755 Fix #37740: Cast all Request parameter values to string (rgeraads)

fabpot · fabpot · commit 6539a0fc2f71 · 2020-08-18T16:07:52.000+02:00
This PR was squashed before being merged into the 5.2-dev branch. Discussion ---------- Fix #37740: Cast all Request parameter values to string | Q | A | ------------- | --- | Branch? | 5.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #37740| License | MIT This fix ensures that all parameter values in Browserkit\Request are received as strings on the receiving end. Commits ------- d4e2cec Fix #37740: Cast all Request parameter values to string
diff --git a/src/Symfony/Component/BrowserKit/Request.php b/src/Symfony/Component/BrowserKit/Request.php
@@ -37,6 +37,11 @@ public function __construct(string $uri, string $method, array $parameters = [],
     {
         $this->uri = $uri;
         $this->method = $method;
+
+        array_walk_recursive($parameters, static function (&$value) {
+            $value = (string) $value;
+        });
+
         $this->parameters = $parameters;
         $this->files = $files;
         $this->cookies = $cookies;
diff --git a/src/Symfony/Component/BrowserKit/Tests/RequestTest.php b/src/Symfony/Component/BrowserKit/Tests/RequestTest.php
@@ -51,4 +51,24 @@ public function testGetServer()
         $request = new Request('http://www.example.com/', 'get', [], [], [], ['foo' => 'bar']);
         $this->assertEquals(['foo' => 'bar'], $request->getServer(), '->getServer() returns the server parameters of the request');
     }
+
+    public function testAllParameterValuesAreConvertedToString(): void
+    {
+        $parameters = [
+            'foo' => 1,
+            'bar' => [
+                'baz' => 2,
+            ],
+        ];
+
+        $expected = [
+            'foo' => '1',
+            'bar' => [
+                'baz' => '2',
+            ],
+        ];
+
+        $request = new Request('http://www.example.com/', 'get', $parameters);
+        $this->assertSame($expected, $request->getParameters());
+    }
 }
