Making minor fixes thanks to comments

weaverryan · weaverryan · commit 6188f9e98873 · 2016-03-24T19:15:12.000-04:00
diff --git a/src/Symfony/Component/Security/Guard/Authenticator/AbstractFormLoginAuthenticator.php b/src/Symfony/Component/Security/Guard/Authenticator/AbstractFormLoginAuthenticator.php
@@ -41,7 +41,7 @@ abstract protected function getLoginUrl();
      * login page directly), this returns the URL the user should be redirected
      * to after logging in successfully (e.g. your homepage).
      *
-     * @deprecated Implement onAuthenticationFailure() instead of needing this function.
+     * @deprecated Implement onAuthenticationSuccess() instead of needing this function.
      *
      * @return string
      */
@@ -79,7 +79,7 @@ public function onAuthenticationSuccess(Request $request, TokenInterface $token,
     {
         @trigger_error(sprintf('The AbstractFormLoginAuthenticator::onAuthenticationSuccess() implementation was deprecated in Symfony 3.1 and will be removed in Symfony 4.0. You should implement this method yourself in %s and remove getDefaultSuccessRedirectUrl().', get_class($this)), E_USER_DEPRECATED);
 
-        // if the user hit a secure page and start() was called, this was
+        // if the user hits a secure page and start() was called, this was
         // the URL they were on, and probably where you want to redirect to
         $targetPath = $this->getTargetPath($request->getSession(), $providerKey);
 
diff --git a/src/Symfony/Component/Security/Guard/Tests/Authenticator/AbstractFormLoginAuthenticatorTest.php b/src/Symfony/Component/Security/Guard/Tests/Authenticator/AbstractFormLoginAuthenticatorTest.php
@@ -34,10 +34,7 @@ public function testLegacyWithLoginUrl()
             'provider_key'
         );
 
-        $this->assertEquals(
-            '/default_url',
-            $actualResponse->getTargetUrl()
-        );
+        $this->assertEquals('/default_url', $actualResponse->getTargetUrl());
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ abstract protected function getLoginUrl();`
`41`	`41`	`* login page directly), this returns the URL the user should be redirected`
`42`	`42`	`* to after logging in successfully (e.g. your homepage).`
`43`	`43`	`*`
`44`		`- * @deprecated Implement onAuthenticationFailure() instead of needing this function.`
	`44`	`+ * @deprecated Implement onAuthenticationSuccess() instead of needing this function.`
`45`	`45`	`*`
`46`	`46`	`* @return string`
`47`	`47`	`*/`
`@@ -79,7 +79,7 @@ public function onAuthenticationSuccess(Request $request, TokenInterface $token,`
`79`	`79`	`{`
`80`	`80`	`@trigger_error(sprintf('The AbstractFormLoginAuthenticator::onAuthenticationSuccess() implementation was deprecated in Symfony 3.1 and will be removed in Symfony 4.0. You should implement this method yourself in %s and remove getDefaultSuccessRedirectUrl().', get_class($this)), E_USER_DEPRECATED);`
`81`	`81`
`82`		`- // if the user hit a secure page and start() was called, this was`
	`82`	`+ // if the user hits a secure page and start() was called, this was`
`83`	`83`	`// the URL they were on, and probably where you want to redirect to`
`84`	`84`	`$targetPath = $this->getTargetPath($request->getSession(), $providerKey);`
`85`	`85`
Original file line number	Diff line number	Diff line change
`@@ -34,10 +34,7 @@ public function testLegacyWithLoginUrl()`
`34`	`34`	`'provider_key'`
`35`	`35`	`);`
`36`	`36`
`37`		`- $this->assertEquals(`
`38`		`- '/default_url',`
`39`		`- $actualResponse->getTargetUrl()`
`40`		`- );`
	`37`	`+ $this->assertEquals('/default_url', $actualResponse->getTargetUrl());`
`41`	`38`	`}`
`42`	`39`	`}`
`43`	`40`